Applied "ASoC: codecs: PCM1789: unconditionally flush work" to the asoc tree

Message ID E1fUsp0-0008P8-DO@debutante
State New
Headers show
  • Applied "ASoC: codecs: PCM1789: unconditionally flush work" to the asoc tree
Related show

Commit Message

Mark Brown June 18, 2018, 11:59 a.m.
The patch

   ASoC: codecs: PCM1789: unconditionally flush work

has been applied to the asoc tree at 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From a7dc662c6a7b9209df600c64b16d33d72dbf56b1 Mon Sep 17 00:00:00 2001
From: Stefan Agner <>

Date: Sun, 17 Jun 2018 15:45:29 +0200
Subject: [PATCH] ASoC: codecs: PCM1789: unconditionally flush work

Work is guaranteed to be initialized on exit. Drop the unnecessary
if statement and always call flush_work.

This fixes a warning seen with clang:
sound/soc/codecs/pcm1789.c:265:13: warning: address of 'priv->work' will
      always evaluate to 'true' [-Wpointer-bool-conversion]
        if (&priv->work)
        ~~   ~~~~~~^~~~

Signed-off-by: Stefan Agner <>

Signed-off-by: Mark Brown <>

 sound/soc/codecs/pcm1789.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


Alsa-devel mailing list


diff --git a/sound/soc/codecs/pcm1789.c b/sound/soc/codecs/pcm1789.c
index 21f15219b3ad..8df6447c76a6 100644
--- a/sound/soc/codecs/pcm1789.c
+++ b/sound/soc/codecs/pcm1789.c
@@ -262,8 +262,7 @@  int pcm1789_common_exit(struct device *dev)
 	struct pcm1789_private *priv = dev_get_drvdata(dev);
-	if (&priv->work)
-		flush_work(&priv->work);
+	flush_work(&priv->work);
 	return 0;