diff mbox series

[edk2,2/2] Embedded/EmbeddedPkg.dsc: enable NOOPT build target

Message ID 20180618165144.8244-2-ard.biesheuvel@linaro.org
State Accepted
Commit a50aa9dd88818854ccde20fdf1b7b9286dc6076c
Headers show
Series [edk2,1/2] ArmPkg/ArmPkg.dsc: enable NOOPT build target | expand

Commit Message

Ard Biesheuvel June 18, 2018, 4:51 p.m. UTC
Enable to NOOPT build target so we can build this package with
optimizations disabled.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm June 18, 2018, 5:33 p.m. UTC | #1
On Mon, Jun 18, 2018 at 06:51:44PM +0200, Ard Biesheuvel wrote:
> Enable to NOOPT build target so we can build this package with

> optimizations disabled.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


For series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>



> ---

>  EmbeddedPkg/EmbeddedPkg.dsc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc

> index e6fad5e58b2d..3914eb7cfa5a 100644

> --- a/EmbeddedPkg/EmbeddedPkg.dsc

> +++ b/EmbeddedPkg/EmbeddedPkg.dsc

> @@ -28,7 +28,7 @@ [Defines]

>    DSC_SPECIFICATION              = 0x00010005

>    OUTPUT_DIRECTORY               = Build/Embedded

>    SUPPORTED_ARCHITECTURES        = IA32|X64|IPF|ARM|AARCH64

> -  BUILD_TARGETS                  = DEBUG|RELEASE

> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>    SKUID_IDENTIFIER               = DEFAULT

>  

>  

> -- 

> 2.17.1

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel June 18, 2018, 5:36 p.m. UTC | #2
On 18 June 2018 at 19:33, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Mon, Jun 18, 2018 at 06:51:44PM +0200, Ard Biesheuvel wrote:

>> Enable to NOOPT build target so we can build this package with

>> optimizations disabled.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.1

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>

> For series:

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Thanks

Pushed as 11d0cd23dd1b..a50aa9dd8881

>

>> ---

>>  EmbeddedPkg/EmbeddedPkg.dsc | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc

>> index e6fad5e58b2d..3914eb7cfa5a 100644

>> --- a/EmbeddedPkg/EmbeddedPkg.dsc

>> +++ b/EmbeddedPkg/EmbeddedPkg.dsc

>> @@ -28,7 +28,7 @@ [Defines]

>>    DSC_SPECIFICATION              = 0x00010005

>>    OUTPUT_DIRECTORY               = Build/Embedded

>>    SUPPORTED_ARCHITECTURES        = IA32|X64|IPF|ARM|AARCH64

>> -  BUILD_TARGETS                  = DEBUG|RELEASE

>> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT

>>    SKUID_IDENTIFIER               = DEFAULT

>>

>>

>> --

>> 2.17.1

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
index e6fad5e58b2d..3914eb7cfa5a 100644
--- a/EmbeddedPkg/EmbeddedPkg.dsc
+++ b/EmbeddedPkg/EmbeddedPkg.dsc
@@ -28,7 +28,7 @@  [Defines]
   DSC_SPECIFICATION              = 0x00010005
   OUTPUT_DIRECTORY               = Build/Embedded
   SUPPORTED_ARCHITECTURES        = IA32|X64|IPF|ARM|AARCH64
-  BUILD_TARGETS                  = DEBUG|RELEASE
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
   SKUID_IDENTIFIER               = DEFAULT