From patchwork Tue Jun 19 05:38:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 139080 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4781593lji; Mon, 18 Jun 2018 22:38:55 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK1sXksR2JnQNVp4OXs3mzIKJ4ZmlAWfptmeUzZWjKwQFo6VYian/+gQqIhVBUqtjqfyrK5 X-Received: by 2002:a62:1146:: with SMTP id z67-v6mr16410409pfi.135.1529386734998; Mon, 18 Jun 2018 22:38:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529386734; cv=none; d=google.com; s=arc-20160816; b=SKHdfX3bZsurl7Lysy9BvlnRi9r8b/ebhiWybX0fA365IDygFpPC9IBrmylQ7Cy7as 27ZzNeIfN3aJ8NGxNIrcI/pRFEsg/gIp1BF9bMgvH7xPLjrHj8VijIhw4ctrvMCWuh7c i5StHLbliBe+YJiVvPnPGAMoODqvcsVIERbXWg+LYviZmjzh9Z15iaiJVpfIy4uQ1Uj4 UGxKzJXtwZ/Cax7lqbHYwoYel3iO+oO4yT5aM6/HXv8LNwhBGEWDoFV1MmtbSNZTbUpr I+9af054lStWuMTdSBg6M1QmKzb28OGSLcmhGvI+0I2NcrOouRp0fr8/Wfu5DmBeYbJO VaRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=DiSUr2v1WBsHNzIFA3QwG98Nklmh5pCYfsmZXjMsHh4=; b=cRaZe4L09R3vLG3Ralp957WnFW/zeonF3M63Ekl1BjvVcOxUxYgB6kqSwSkwcexkPX 3K9jSaB/qH6QRayrGEEU6JW4qn1FWIJumFlIIdzMjgTmM8KK0mK5ZfRDqis/ESLON27K 0anhnouMKX8nJNrL/a5XRoX86asPX8dcdQQmTS5OVUmyt+XC0TONLx/nhbnW4DeN6hNH MnTcrYlUy2sbT3ytuu00q153bw2m+o8aGhpfEe39rH4iJvzeiL6JKyNRos57IqfLfWAt k2Hzmqm6wcTk0bKJd1mJQwhi/65TBvbmCEZXz7ERg8e1crLne2D5hdXbncwWHMi9uP1r 5MYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="jwKcRkF/"; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2-v6si16740810plh.136.2018.06.18.22.38.54; Mon, 18 Jun 2018 22:38:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="jwKcRkF/"; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755890AbeFSFiw (ORCPT + 9 others); Tue, 19 Jun 2018 01:38:52 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:36821 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755840AbeFSFiv (ORCPT ); Tue, 19 Jun 2018 01:38:51 -0400 Received: by mail-pl0-f66.google.com with SMTP id a7-v6so10311337plp.3 for ; Mon, 18 Jun 2018 22:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=DiSUr2v1WBsHNzIFA3QwG98Nklmh5pCYfsmZXjMsHh4=; b=jwKcRkF/hi6YLeUJH1CTG7FqqhgFvqh1vjoDoe/NC3HwdfS77WCrReEDJV7TSeERWy 4kQy/Zu26ChDsBOYCbeIg/Y/6QoscDkiVVeY4LG1XFxLFzlMYVKqzlBuUb0t7moLT99r MiYZupx0ZyCpjy6agKBjbZG8c7888SPBhM7ENzEC00QW66kbQRpgc+PgqMFcogdqmass Riwf3dgylLF4+TvUgo9DBXgztiik9oata/MUuJ5vTZkpLyQdUXCdM4Vq7TJ6/g0AXyER dAGtAwVJrJ1VHJYQ9xuWPdkRTV729ogWduHdZxyzrJtMmMroJ0zugs7seuW5ZrLqpese M8cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=DiSUr2v1WBsHNzIFA3QwG98Nklmh5pCYfsmZXjMsHh4=; b=FzEsft9Iv8nLeTy1jXr95Sm52YmlIJPD4AvB+PE0lZIUyEHJg9V8o8kuAb0NoTA2Jv jA7//HZ86VECYqU/vWr3XDpq6HFcMMUH/Qfm9P1OsO55rlNG3n3ni+GnW1RVj8xi/krW Uf8oUHfBUGsIPZbrevfuJtHAtLBY8Cax7z9F4bX/mD00CBI4RE/OLPykFuv4M37B3L4K UDrFpvEKKOkHwWdSUZmGWXVtOmjDcpEh4rolEusEDV5b4k8huYLOfbJYW6PGA/lOoCAi eetZ1ewV3HUXQLvLfchDpqwQolFzMuYvMgCWKdFXCrbpChVaKXtIlWfCoqO02BZsww0A Oubw== X-Gm-Message-State: APt69E0jsNZT8JKG04S5mYBz8Cdty0cQ9iQMHonKOb8IDp5qU5LCE58C rY1t9daHOFS/FM9HW5lOTmfEZCPrJA0= X-Received: by 2002:a17:902:52ee:: with SMTP id a101-v6mr17067243pli.131.1529386730698; Mon, 18 Jun 2018 22:38:50 -0700 (PDT) Received: from aurora.jms.id.au ([58.175.208.48]) by smtp.gmail.com with ESMTPSA id h84-v6sm26183220pfd.69.2018.06.18.22.38.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Jun 2018 22:38:50 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Tue, 19 Jun 2018 15:08:44 +0930 From: Joel Stanley To: Samuel Mendoza-Jonas , "David S . Miller" Cc: netdev@vger.kernel.org, Joe Perches Subject: [PATCH v2 1/4] net/ncsi: Silence debug messages Date: Tue, 19 Jun 2018 15:08:31 +0930 Message-Id: <20180619053834.12257-2-joel@jms.id.au> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180619053834.12257-1-joel@jms.id.au> References: <20180619053834.12257-1-joel@jms.id.au> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In normal operation we see this series of messages as the host drives the network device: ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state down ftgmac100 1e660000.ethernet eth0: NCSI: suspending channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI: channel 0 link down after config ftgmac100 1e660000.ethernet eth0: NCSI interface down ftgmac100 1e660000.ethernet eth0: NCSI: LSC AEN - channel 0 state up ftgmac100 1e660000.ethernet eth0: NCSI: configuring channel 0 ftgmac100 1e660000.ethernet eth0: NCSI interface up This makes all of these messages netdev_dbg. They are still useful to debug eg. misbehaving network device firmware, but we do not need them filling up the kernel logs in normal operation. Acked-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley --- v2: Fix alignment in ftgmac100 change --- drivers/net/ethernet/faraday/ftgmac100.c | 4 ++-- net/ncsi/ncsi-aen.c | 4 ++-- net/ncsi/ncsi-manage.c | 14 +++++++------- 3 files changed, 11 insertions(+), 11 deletions(-) -- 2.17.1 diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c index 78db8e62a83f..ed6c76d20b45 100644 --- a/drivers/net/ethernet/faraday/ftgmac100.c +++ b/drivers/net/ethernet/faraday/ftgmac100.c @@ -1735,8 +1735,8 @@ static void ftgmac100_ncsi_handler(struct ncsi_dev *nd) if (unlikely(nd->state != ncsi_dev_state_functional)) return; - netdev_info(nd->dev, "NCSI interface %s\n", - nd->link_up ? "up" : "down"); + netdev_dbg(nd->dev, "NCSI interface %s\n", + nd->link_up ? "up" : "down"); } static void ftgmac100_setup_clk(struct ftgmac100 *priv) diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c index e7b05de1e6d1..f899ed61bb57 100644 --- a/net/ncsi/ncsi-aen.c +++ b/net/ncsi/ncsi-aen.c @@ -73,8 +73,8 @@ static int ncsi_aen_handler_lsc(struct ncsi_dev_priv *ndp, ncm->data[2] = data; ncm->data[4] = ntohl(lsc->oem_status); - netdev_info(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", - nc->id, data & 0x1 ? "up" : "down"); + netdev_dbg(ndp->ndev.dev, "NCSI: LSC AEN - channel %u state %s\n", + nc->id, data & 0x1 ? "up" : "down"); chained = !list_empty(&nc->link); state = nc->state; diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c index 5561e221b71f..616441c2b54f 100644 --- a/net/ncsi/ncsi-manage.c +++ b/net/ncsi/ncsi-manage.c @@ -816,9 +816,9 @@ static void ncsi_configure_channel(struct ncsi_dev_priv *ndp) } else { hot_nc = NULL; nc->state = NCSI_CHANNEL_INACTIVE; - netdev_warn(ndp->ndev.dev, - "NCSI: channel %u link down after config\n", - nc->id); + netdev_dbg(ndp->ndev.dev, + "NCSI: channel %u link down after config\n", + nc->id); } spin_unlock_irqrestore(&nc->lock, flags); @@ -1199,14 +1199,14 @@ int ncsi_process_next_channel(struct ncsi_dev_priv *ndp) switch (old_state) { case NCSI_CHANNEL_INACTIVE: ndp->ndev.state = ncsi_dev_state_config; - netdev_info(ndp->ndev.dev, "NCSI: configuring channel %u\n", - nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: configuring channel %u\n", + nc->id); ncsi_configure_channel(ndp); break; case NCSI_CHANNEL_ACTIVE: ndp->ndev.state = ncsi_dev_state_suspend; - netdev_info(ndp->ndev.dev, "NCSI: suspending channel %u\n", - nc->id); + netdev_dbg(ndp->ndev.dev, "NCSI: suspending channel %u\n", + nc->id); ncsi_suspend_channel(ndp); break; default: