diff mbox series

Add HXT Phecda core support

Message ID 1529463260-5898-1-git-send-email-hongbo.zhang@linaro.org
State Superseded
Headers show
Series Add HXT Phecda core support | expand

Commit Message

Hongbo Zhang June 20, 2018, 2:54 a.m. UTC 
HXT semiconductor's CPU core Phecda, as a variant of Qualcomm qdf24xx,
reuses the same tuning structure and pipeline with it.

2018-06-19  Hongbo Zhang  <hongbo.zhang@linaro.org>

	* config/aarch64/aarch64-cores.def (AARCH64_CORE): add phecda core
	* config/aarch64/aarch64-tune.md: re-generated by gentune.sh
	* doc/invoke.texi: add phecda core entry
---
 gcc/config/aarch64/aarch64-cores.def | 3 +++
 gcc/config/aarch64/aarch64-tune.md   | 2 +-
 gcc/doc/invoke.texi                  | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

-- 
2.7.4

Comments

Kyrill Tkachov June 21, 2018, 9:30 a.m. UTC | #1 
Hi Hongbo,

On 20/06/18 03:54, Hongbo Zhang wrote:
> HXT semiconductor's CPU core Phecda, as a variant of Qualcomm qdf24xx,

> reuses the same tuning structure and pipeline with it.

>


This looks ok to me but you'll need approval from the maintainers.
Some comments on the ChangeLog below.

> 2018-06-19  Hongbo Zhang  <hongbo.zhang@linaro.org>

>

>         * config/aarch64/aarch64-cores.def (AARCH64_CORE): add phecda core

>         * config/aarch64/aarch64-tune.md: re-generated by gentune.sh

>         * doc/invoke.texi: add phecda core entry


Please use capital first letter and end the sentence with a full stop.
That is, "Add phecda core." Same for the other entries
For aarch64-tune.md you can just say "Regenerate."

Thanks,
Kyrill

> ---

>  gcc/config/aarch64/aarch64-cores.def | 3 +++

>  gcc/config/aarch64/aarch64-tune.md   | 2 +-

>  gcc/doc/invoke.texi                  | 2 +-

>  3 files changed, 5 insertions(+), 2 deletions(-)

>

> diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def

> index e64d831..0e3c0a0 100644

> --- a/gcc/config/aarch64/aarch64-cores.def

> +++ b/gcc/config/aarch64/aarch64-cores.def

> @@ -61,6 +61,9 @@ AARCH64_CORE("thunderxt88", thunderxt88,   thunderx,  8A,  AARCH64_FL_FOR_ARCH

>  AARCH64_CORE("thunderxt81",   thunderxt81,   thunderx, 8A,  AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx,  0x43, 0x0a2, -1)

>  AARCH64_CORE("thunderxt83",   thunderxt83,   thunderx, 8A,  AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx,  0x43, 0x0a3, -1)

>

> +/* HXT ('H') cores. */

> +AARCH64_CORE("phecda",      phecda,    falkor,    8A, AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, qdf24xx,   0x68, 0x000, -1)

> +

>  /* APM ('P') cores. */

>  AARCH64_CORE("xgene1",      xgene1,    xgene1,    8A, AARCH64_FL_FOR_ARCH8, xgene1, 0x50, 0x000, -1)

>

> diff --git a/gcc/config/aarch64/aarch64-tune.md b/gcc/config/aarch64/aarch64-tune.md

> index 7b3a746..19b44d7 100644

> --- a/gcc/config/aarch64/aarch64-tune.md

> +++ b/gcc/config/aarch64/aarch64-tune.md

> @@ -1,5 +1,5 @@

>  ;; -*- buffer-read-only: t -*-

>  ;; Generated automatically by gentune.sh from aarch64-cores.def

>  (define_attr "tune"

> - "cortexa35,cortexa53,cortexa57,cortexa72,cortexa73,thunderx,thunderxt88p1,thunderxt88,thunderxt81,thunderxt83,xgene1,falkor,qdf24xx,exynosm1,thunderx2t99p1,vulcan,thunderx2t99,cortexa55,cortexa75,saphira,cortexa57cortexa53,cortexa72cortexa53,cortexa73cortexa35,cortexa73cortexa53,cortexa75cortexa55"

> + "cortexa35,cortexa53,cortexa57,cortexa72,cortexa73,thunderx,thunderxt88p1,thunderxt88,thunderxt81,thunderxt83,phecda,xgene1,falkor,qdf24xx,exynosm1,thunderx2t99p1,vulcan,thunderx2t99,cortexa55,cortexa75,saphira,cortexa57cortexa53,cortexa72cortexa53,cortexa73cortexa35,cortexa73cortexa53,cortexa75cortexa55"

>          (const (symbol_ref "((enum attr_tune) aarch64_tune)")))

> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi

> index 940b846..43ef9ac 100644

> --- a/gcc/doc/invoke.texi

> +++ b/gcc/doc/invoke.texi

> @@ -14667,7 +14667,7 @@ performance of the code. Permissible values for this option are:

>  @samp{generic}, @samp{cortex-a35}, @samp{cortex-a53}, @samp{cortex-a55},

>  @samp{cortex-a57}, @samp{cortex-a72}, @samp{cortex-a73}, @samp{cortex-a75},

>  @samp{exynos-m1}, @samp{falkor}, @samp{qdf24xx}, @samp{saphira},

> -@samp{xgene1}, @samp{vulcan}, @samp{thunderx},

> +@samp{phecda}, @samp{xgene1}, @samp{vulcan}, @samp{thunderx},

>  @samp{thunderxt88}, @samp{thunderxt88p1}, @samp{thunderxt81},

>  @samp{thunderxt83}, @samp{thunderx2t99}, @samp{cortex-a57.cortex-a53},

>  @samp{cortex-a72.cortex-a53}, @samp{cortex-a73.cortex-a35},

> -- 

> 2.7.4

>
Hongbo Zhang June 22, 2018, 4:24 a.m. UTC | #2 
On 21 June 2018 at 17:30, Kyrill  Tkachov <kyrylo.tkachov@foss.arm.com> wrote:
> Hi Hongbo,

>

> On 20/06/18 03:54, Hongbo Zhang wrote:

>>

>> HXT semiconductor's CPU core Phecda, as a variant of Qualcomm qdf24xx,

>> reuses the same tuning structure and pipeline with it.

>>

>

> This looks ok to me but you'll need approval from the maintainers.

> Some comments on the ChangeLog below.

>

>> 2018-06-19  Hongbo Zhang  <hongbo.zhang@linaro.org>

>>

>>         * config/aarch64/aarch64-cores.def (AARCH64_CORE): add phecda core

>>         * config/aarch64/aarch64-tune.md: re-generated by gentune.sh

>>         * doc/invoke.texi: add phecda core entry

>

>

> Please use capital first letter and end the sentence with a full stop.

> That is, "Add phecda core." Same for the other entries

> For aarch64-tune.md you can just say "Regenerate."

>

Get it, thanks Kyrill.

> Thanks,

> Kyrill

>

>

>> ---

>>  gcc/config/aarch64/aarch64-cores.def | 3 +++

>>  gcc/config/aarch64/aarch64-tune.md   | 2 +-

>>  gcc/doc/invoke.texi                  | 2 +-

>>  3 files changed, 5 insertions(+), 2 deletions(-)

>>

>> diff --git a/gcc/config/aarch64/aarch64-cores.def

>> b/gcc/config/aarch64/aarch64-cores.def

>> index e64d831..0e3c0a0 100644

>> --- a/gcc/config/aarch64/aarch64-cores.def

>> +++ b/gcc/config/aarch64/aarch64-cores.def

>> @@ -61,6 +61,9 @@ AARCH64_CORE("thunderxt88", thunderxt88,   thunderx,

>> 8A,  AARCH64_FL_FOR_ARCH

>>  AARCH64_CORE("thunderxt81",   thunderxt81,   thunderx, 8A,

>> AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx,  0x43,

>> 0x0a2, -1)

>>  AARCH64_CORE("thunderxt83",   thunderxt83,   thunderx, 8A,

>> AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx,  0x43,

>> 0x0a3, -1)

>>

>> +/* HXT ('H') cores. */

>> +AARCH64_CORE("phecda",      phecda,    falkor,    8A,

>> AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, qdf24xx,   0x68,

>> 0x000, -1)

>> +

>>  /* APM ('P') cores. */

>>  AARCH64_CORE("xgene1",      xgene1,    xgene1,    8A,

>> AARCH64_FL_FOR_ARCH8, xgene1, 0x50, 0x000, -1)

>>

>> diff --git a/gcc/config/aarch64/aarch64-tune.md

>> b/gcc/config/aarch64/aarch64-tune.md

>> index 7b3a746..19b44d7 100644

>> --- a/gcc/config/aarch64/aarch64-tune.md

>> +++ b/gcc/config/aarch64/aarch64-tune.md

>> @@ -1,5 +1,5 @@

>>  ;; -*- buffer-read-only: t -*-

>>  ;; Generated automatically by gentune.sh from aarch64-cores.def

>>  (define_attr "tune"

>> -

>> "cortexa35,cortexa53,cortexa57,cortexa72,cortexa73,thunderx,thunderxt88p1,thunderxt88,thunderxt81,thunderxt83,xgene1,falkor,qdf24xx,exynosm1,thunderx2t99p1,vulcan,thunderx2t99,cortexa55,cortexa75,saphira,cortexa57cortexa53,cortexa72cortexa53,cortexa73cortexa35,cortexa73cortexa53,cortexa75cortexa55"

>> +

>> "cortexa35,cortexa53,cortexa57,cortexa72,cortexa73,thunderx,thunderxt88p1,thunderxt88,thunderxt81,thunderxt83,phecda,xgene1,falkor,qdf24xx,exynosm1,thunderx2t99p1,vulcan,thunderx2t99,cortexa55,cortexa75,saphira,cortexa57cortexa53,cortexa72cortexa53,cortexa73cortexa35,cortexa73cortexa53,cortexa75cortexa55"

>>          (const (symbol_ref "((enum attr_tune) aarch64_tune)")))

>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi

>> index 940b846..43ef9ac 100644

>> --- a/gcc/doc/invoke.texi

>> +++ b/gcc/doc/invoke.texi

>> @@ -14667,7 +14667,7 @@ performance of the code. Permissible values for

>> this option are:

>>  @samp{generic}, @samp{cortex-a35}, @samp{cortex-a53}, @samp{cortex-a55},

>>  @samp{cortex-a57}, @samp{cortex-a72}, @samp{cortex-a73},

>> @samp{cortex-a75},

>>  @samp{exynos-m1}, @samp{falkor}, @samp{qdf24xx}, @samp{saphira},

>> -@samp{xgene1}, @samp{vulcan}, @samp{thunderx},

>> +@samp{phecda}, @samp{xgene1}, @samp{vulcan}, @samp{thunderx},

>>  @samp{thunderxt88}, @samp{thunderxt88p1}, @samp{thunderxt81},

>>  @samp{thunderxt83}, @samp{thunderx2t99}, @samp{cortex-a57.cortex-a53},

>>  @samp{cortex-a72.cortex-a53}, @samp{cortex-a73.cortex-a35},

>> --

>> 2.7.4

>>

>
diff mbox series

Patch

diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def
index e64d831..0e3c0a0 100644
--- a/gcc/config/aarch64/aarch64-cores.def
+++ b/gcc/config/aarch64/aarch64-cores.def
@@ -61,6 +61,9 @@  AARCH64_CORE("thunderxt88",   thunderxt88,   thunderx,  8A,  AARCH64_FL_FOR_ARCH
 AARCH64_CORE("thunderxt81",   thunderxt81,   thunderx,  8A,  AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx,  0x43, 0x0a2, -1)
 AARCH64_CORE("thunderxt83",   thunderxt83,   thunderx,  8A,  AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx,  0x43, 0x0a3, -1)
 
+/* HXT ('H') cores. */
+AARCH64_CORE("phecda",      phecda,    falkor,    8A,  AARCH64_FL_FOR_ARCH8 | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, qdf24xx,   0x68, 0x000, -1)
+
 /* APM ('P') cores. */
 AARCH64_CORE("xgene1",      xgene1,    xgene1,    8A,  AARCH64_FL_FOR_ARCH8, xgene1, 0x50, 0x000, -1)
 
diff --git a/gcc/config/aarch64/aarch64-tune.md b/gcc/config/aarch64/aarch64-tune.md
index 7b3a746..19b44d7 100644
--- a/gcc/config/aarch64/aarch64-tune.md
+++ b/gcc/config/aarch64/aarch64-tune.md
@@ -1,5 +1,5 @@ 
 ;; -*- buffer-read-only: t -*-
 ;; Generated automatically by gentune.sh from aarch64-cores.def
 (define_attr "tune"
-	"cortexa35,cortexa53,cortexa57,cortexa72,cortexa73,thunderx,thunderxt88p1,thunderxt88,thunderxt81,thunderxt83,xgene1,falkor,qdf24xx,exynosm1,thunderx2t99p1,vulcan,thunderx2t99,cortexa55,cortexa75,saphira,cortexa57cortexa53,cortexa72cortexa53,cortexa73cortexa35,cortexa73cortexa53,cortexa75cortexa55"
+	"cortexa35,cortexa53,cortexa57,cortexa72,cortexa73,thunderx,thunderxt88p1,thunderxt88,thunderxt81,thunderxt83,phecda,xgene1,falkor,qdf24xx,exynosm1,thunderx2t99p1,vulcan,thunderx2t99,cortexa55,cortexa75,saphira,cortexa57cortexa53,cortexa72cortexa53,cortexa73cortexa35,cortexa73cortexa53,cortexa75cortexa55"
 	(const (symbol_ref "((enum attr_tune) aarch64_tune)")))
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 940b846..43ef9ac 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -14667,7 +14667,7 @@  performance of the code.  Permissible values for this option are:
 @samp{generic}, @samp{cortex-a35}, @samp{cortex-a53}, @samp{cortex-a55},
 @samp{cortex-a57}, @samp{cortex-a72}, @samp{cortex-a73}, @samp{cortex-a75},
 @samp{exynos-m1}, @samp{falkor}, @samp{qdf24xx}, @samp{saphira},
-@samp{xgene1}, @samp{vulcan}, @samp{thunderx},
+@samp{phecda}, @samp{xgene1}, @samp{vulcan}, @samp{thunderx},
 @samp{thunderxt88}, @samp{thunderxt88p1}, @samp{thunderxt81},
 @samp{thunderxt83}, @samp{thunderx2t99}, @samp{cortex-a57.cortex-a53},
 @samp{cortex-a72.cortex-a53}, @samp{cortex-a73.cortex-a35},