From patchwork Sat Jun 23 13:56:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 139755 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp2032605lji; Sat, 23 Jun 2018 06:58:33 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJOUMuZcFrLa38z1dYv/dnYh6XzloOrLHL3Px0RWShtZaaEau4L5yg7WFVbwVsd4+74G+oX X-Received: by 2002:a17:902:758e:: with SMTP id j14-v6mr5589780pll.160.1529762313222; Sat, 23 Jun 2018 06:58:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529762313; cv=none; d=google.com; s=arc-20160816; b=YnxrymTq5aWC/BL3SQSLBwDt1i1S7ob1IvxX7Pr/5rgkBc/Zt9g9bDeHWsbYMNR+0R lZVCyIZIA9FGRiphrx5TDm22vo/FttlmJqTGGNf/vUMJj2o3IJBiKnzmHiaOeSEcbMP2 J4erJVu4X4eaiwu2uhcR1LFlOkRqOdFcyNA1aPWQP6wN9zMTOQHtCDlci51nYgA7tOkZ 9GS4ZQsqyHfKoSDeEVMAYiEv+v1s59ecEDm3o/HYi8lKqofivwgLFtnMqGpg1BFecrQp K1y1q24PLZMnhrPehWtnqEPzFZd3e7bM87S9M28yfDIlo1i2THorm2XUPp1X3SHnyRxs xcAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=BhaTLl7qF75US9NEVf7QohyaPmquhej9ID5Zt2moriM=; b=I0ovOgKAIk7xmS42lVFQ+vLB3m3/3PLlLAmzOJacR1UDqp9ZgbF485eO4jKW7pWtPm roqWZMa3aW+5WcEdOXeEMUfx52lsBLVGvkacWs1qGByJD6zsXHsC9HHc284igwpE0iZb HScGcm7olUyddfxYN5HGj4eSDxFUHXGz4y84kB3NIsxoRvjbYXhP3PhteBDnMCGUXhrO m9++8ZOaiR/EifyuWTqNbI1q3lc3CD5jwnmTgOrIsbA8KshuDhJ40zefOZ16qOV/0B4B 7s2+23yJxVYVbnYCK3DFUl6rhKGEaPMVoHVVdr/A5mJCvXj36qcF4Lt2TP97xzKkIzCW W3Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=vqNUMFyh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w65-v6si9949112pfb.309.2018.06.23.06.58.32; Sat, 23 Jun 2018 06:58:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=vqNUMFyh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751723AbeFWN6Q (ORCPT + 31 others); Sat, 23 Jun 2018 09:58:16 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:44603 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbeFWN6N (ORCPT ); Sat, 23 Jun 2018 09:58:13 -0400 Received: from grover.sesame (FL1-125-199-20-195.osk.mesh.ad.jp [125.199.20.195]) (authenticated) by conuserg-08.nifty.com with ESMTP id w5NDvYBV015690; Sat, 23 Jun 2018 22:57:35 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com w5NDvYBV015690 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1529762256; bh=BhaTLl7qF75US9NEVf7QohyaPmquhej9ID5Zt2moriM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vqNUMFyhWkX8T7CTOVceTK5PSM6BqBOsB5zkOJ/q71NM1qFCTdZvv6mb6qYGayT9R IUE9AiQzzpKp2FHmkaoKmIOJc1t5CiLkguDEjUDQnOJu7uOea5h2jkB0SFD4Cvxr5p EYCRxJHd1Bq/zgW1zyPnLPRnLb0GipUu9O3otKLNF5iJbncE76WmVNuJEPiKXS+v5f MMkrNMKBsDRtnoqa12qlFl6GTtDH20eEmC8/sNMNSZacbT1pYExkq9Yz6YndfzucRh VFHK2C+ltjJV2ysPYIbTp6QYWmad7wlO59Z5+kCoz/Ql+AOvZ4hSrY9MFa/gCcQF24 UhVFJygt6M3Fg== X-Nifty-SrcIP: [125.199.20.195] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Masahiro Yamada , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] kbuild: do not update config when running install targets Date: Sat, 23 Jun 2018 22:56:08 +0900 Message-Id: <1529762169-13488-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529762169-13488-1-git-send-email-yamada.masahiro@socionext.com> References: <1529762169-13488-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "make syncconfig" is automatically invoked when any of the following happens: - .config is updated - any of Kconfig files is updated - any of environment variables referenced in Kconfig is changed Then, it updates configuration files such as include/config/auto.conf include/generated/autoconf.h, etc. Even install targets (install, modules_install, etc.) are no exception. However, they should never ever modify the source tree. Install targets are often run with root privileges. Once those configuration files are owned by root, "make mrproper" would end up with permission error. Install targets should just copy things blindly. They should not care whether the configuration is up-to-date or not. This makes more sense because we are interested in the configuration that was used in the previous kernel building. This issue has existed since before, but rarely happened. I expect more chance where people are hit by this; with the new Kconfig syntax extension, the .config now contains the compiler information. If you cross-compile the kernel with CROSS_COMPILE, but forget to pass it for "make install", you meet "any of environment variables referenced in Kconfig is changed" because $(CC) is referenced in Kconfig. Another scenario is the compiler upgrade before the installation. Install targets need the configuration. "make modules_install" refer to CONFIG_MODULES etc. "make dtbs_install" also needs CONFIG_ARCH_* to decide which dtb files to install. However, the auto-update of the configuration files should be avoided. We already do this for external modules. Now, Make targets are categorized into 3 groups: [1] Do not need the kernel configuration at all help, coccicheck, headers_install etc. [2] Need the latest kernel configuration If new config options are added, Kconfig will show prompt to ask user's selection. Build targets such as vmlinux, in-kernel modules are the cases. [3] Need the kernel configuration, but do not want to update it Install targets except headers_install, and external modules are the cases. Signed-off-by: Masahiro Yamada --- Changes in v2: None Makefile | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/Makefile b/Makefile index 413c2ed..f1e06fba 100644 --- a/Makefile +++ b/Makefile @@ -225,10 +225,12 @@ no-dot-config-targets := $(clean-targets) \ cscope gtags TAGS tags help% %docs check% coccicheck \ $(version_h) headers_% archheaders archscripts \ kernelversion %src-pkg +no-sync-config-targets := $(no-dot-config-targets) install %install -config-targets := 0 -mixed-targets := 0 -dot-config := 1 +config-targets := 0 +mixed-targets := 0 +dot-config := 1 +may-sync-config := 1 ifneq ($(filter $(no-dot-config-targets), $(MAKECMDGOALS)),) ifeq ($(filter-out $(no-dot-config-targets), $(MAKECMDGOALS)),) @@ -236,6 +238,16 @@ ifneq ($(filter $(no-dot-config-targets), $(MAKECMDGOALS)),) endif endif +ifneq ($(filter $(no-sync-config-targets), $(MAKECMDGOALS)),) + ifeq ($(filter-out $(no-sync-config-targets), $(MAKECMDGOALS)),) + may-sync-config := 0 + endif +endif + +ifneq ($(KBUILD_EXTMOD),) + may-sync-config := 0 +endif + ifeq ($(KBUILD_EXTMOD),) ifneq ($(filter config %config,$(MAKECMDGOALS)),) config-targets := 1 @@ -611,7 +623,7 @@ ARCH_CFLAGS := include arch/$(SRCARCH)/Makefile ifeq ($(dot-config),1) -ifeq ($(KBUILD_EXTMOD),) +ifeq ($(may-sync-config),1) # Read in dependencies to all Kconfig* files, make sure to run syncconfig if # changes are detected. This should be included after arch/$(SRCARCH)/Makefile # because some architectures define CROSS_COMPILE there. @@ -639,7 +651,7 @@ include/config/auto.conf: echo >&2 ; \ /bin/false) -endif # KBUILD_EXTMOD +endif # may-sync-config else # Dummy target needed, because used as prerequisite