From patchwork Mon Jun 25 20:05:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksandar Markovic X-Patchwork-Id: 139889 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4389666lji; Mon, 25 Jun 2018 13:09:40 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ/kGHtWPotOsGvw4FQI9Y2WeiLb/cIMZ/5dU3KW1cPBZsblUXntpMt59RUVKxPJ3FvLxyZ X-Received: by 2002:ac8:2acb:: with SMTP id c11-v6mr12520808qta.147.1529957379959; Mon, 25 Jun 2018 13:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529957379; cv=none; d=google.com; s=arc-20160816; b=xfdqqivqkRv7zGxYk3bQphMPjdFi6OWhyZ3fmB1tpjYMZNU/GVpGLw2RAdHdYdungJ QtrMwzkcGAeaBEse1Du/6drjDAixsCP6tTEWpZ345OsxBgqlMGnocxynBYKnUXOB9RrB RL1LzLMKG1wYI7iqNbBjXKwMjXUOp/DBIiDCK6Khcl0B3Wb5GSe8vEGNfl08ZfafCxRu weroibAbPs3oDAWaN/KmAu0qVxrhdyOCvhJH7vypnsUj6iYae/afiei788/CSUyS6dWX wbi4IwA4IIcQYS1YMb+A27TC6U2GDKRYqNGTFpOZnjm2iPnVfbUcvskEMrR2Uosue/nF Od3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=m21j1VbFxH34aYAN9spcYffhozOBNjSYOioCmo1JxLw=; b=OwEEM554gMoLsL+UatAv1l6LHCSnjfFmw8NBSg3ZugB8NB/ylvSSvbSnxhRHf3+7RI fkUV8ar0o9fhjGS6askSMlL3PDx5qSQm1ZrRZk6kkTSPi2HAKQqfX+38Q/wnWgRNG8Tq dK1QBsUeyvII1rxTKX66Dutf6KDUo7upssrmoiIsQTkGhB9G9XfXb2NvdgyTV3GVZ0u4 ErXhGrNSTWKA88rmks1seIQU0yAMp5WakLx+u6PP3hdc3zGzKYps4t5B4ICZn9OccMHT mR8NC3iuNCkKbns3nxn9ITNvnBOy5sdxCuPhCGwyUyyS6nOBdXuTouCeKHjassA3kWsx yyNQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r8-v6si6623674qte.194.2018.06.25.13.09.39 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 25 Jun 2018 13:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1]:49028 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXXnv-00051T-36 for patch@linaro.org; Mon, 25 Jun 2018 16:09:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXXl4-0002g2-9R for qemu-devel@nongnu.org; Mon, 25 Jun 2018 16:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXXkz-0002M9-I5 for qemu-devel@nongnu.org; Mon, 25 Jun 2018 16:06:42 -0400 Received: from mx2.rt-rk.com ([89.216.37.149]:40228 helo=mail.rt-rk.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fXXkz-00023J-B3 for qemu-devel@nongnu.org; Mon, 25 Jun 2018 16:06:37 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.rt-rk.com (Postfix) with ESMTP id E51D61A2051; Mon, 25 Jun 2018 22:06:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at rt-rk.com Received: from rtrkw774-lin.mipstec.com (unknown [82.117.201.26]) by mail.rt-rk.com (Postfix) with ESMTPSA id A32D51A2007; Mon, 25 Jun 2018 22:06:12 +0200 (CEST) From: Aleksandar Markovic To: qemu-devel@nongnu.org Date: Mon, 25 Jun 2018 22:05:59 +0200 Message-Id: <1529957164-4744-5-git-send-email-aleksandar.markovic@rt-rk.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529957164-4744-1-git-send-email-aleksandar.markovic@rt-rk.com> References: <1529957164-4744-1-git-send-email-aleksandar.markovic@rt-rk.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 89.216.37.149 Subject: [Qemu-devel] [PULL 4/9] hw/pci-host/xilinx-pcie: don't make "io" region be RAM X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Currently we use memory_region_init_rom_nomigrate() to create the "io" memory region to pass to pci_register_root_bus(). This is a dummy region, because this PCI controller doesn't support accesses to PCI IO space. There is no reason for the dummy region to be a RAM region; it is only used as a place where PCI BARs can be mapped, and if you could get a PCI card to do a bus master access to the IO space it should not get acts-like-RAM behaviour. Use a simple container memory region instead. (We do have one PCI card model which can do bus master accesses to IO space -- the LSI53C895A SCSI adaptor.) This avoids the oddity of having a memory region which is RAM but where the RAM is not migrated. Note that the size of the region we use here has no effect on behaviour. Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Signed-off-by: Aleksandar Markovic --- hw/pci-host/xilinx-pcie.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/hw/pci-host/xilinx-pcie.c b/hw/pci-host/xilinx-pcie.c index 044e312..b0a31b9 100644 --- a/hw/pci-host/xilinx-pcie.c +++ b/hw/pci-host/xilinx-pcie.c @@ -120,9 +120,8 @@ static void xilinx_pcie_host_realize(DeviceState *dev, Error **errp) memory_region_init(&s->mmio, OBJECT(s), "mmio", UINT64_MAX); memory_region_set_enabled(&s->mmio, false); - /* dummy I/O region */ - memory_region_init_ram_nomigrate(&s->io, OBJECT(s), "io", 16, NULL); - memory_region_set_enabled(&s->io, false); + /* dummy PCI I/O region (not visible to the CPU) */ + memory_region_init(&s->io, OBJECT(s), "io", 16); /* interrupt out */ qdev_init_gpio_out_named(dev, &s->irq, "interrupt_out", 1);