net: phy: DP83TC811: Fix diabling interrupts

Message ID 20180628121332.10457-1-dmurphy@ti.com
State Superseded
Headers show
Series
  • net: phy: DP83TC811: Fix diabling interrupts
Related show

Commit Message

Dan Murphy June 28, 2018, 12:13 p.m.
Fix a bug where INT_STAT1 was written twice and
INT_STAT2 was ignored when disabling interrupts.

Signed-off-by: Dan Murphy <dmurphy@ti.com>

---
 drivers/net/phy/dp83tc811.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.0.582.gccdcbd54c

Comments

Andrew Lunn June 28, 2018, 12:47 p.m. | #1
On Thu, Jun 28, 2018 at 07:13:32AM -0500, Dan Murphy wrote:
> Fix a bug where INT_STAT1 was written twice and

> INT_STAT2 was ignored when disabling interrupts.


Hi Dan

You should put in the subject line which tree this is for, eg.
[PATCH net].

Also, you should add a fixes tag, indicating when this bug as added.

Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy")

Reviewed-by: Andrew Lunn <andrew@lunn.ch>


    Andrew

Patch

diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c
index 081d99aa3985..49ac678eb2dc 100644
--- a/drivers/net/phy/dp83tc811.c
+++ b/drivers/net/phy/dp83tc811.c
@@ -222,7 +222,7 @@  static int dp83811_config_intr(struct phy_device *phydev)
 		if (err < 0)
 			return err;
 
-		err = phy_write(phydev, MII_DP83811_INT_STAT1, 0);
+		err = phy_write(phydev, MII_DP83811_INT_STAT2, 0);
 	}
 
 	return err;