From patchwork Thu Jun 28 13:32:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 140447 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2195311ljj; Thu, 28 Jun 2018 06:33:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKZq9yJkZLJruTL13c1FtqQkp3rKTP41YtqDzX0zFiONlQb4XWWajbS/gyRBXkX2WsmWhzC X-Received: by 2002:a17:902:aa98:: with SMTP id d24-v6mr10697790plr.185.1530192797740; Thu, 28 Jun 2018 06:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530192797; cv=none; d=google.com; s=arc-20160816; b=U7LAU9Hd9SZrAolhO06kL1BpOYaV4Brx2aFPG6vJvBmNU6PTQEfO0eXsg9p9Owytnf 73+V4knKip/yWfm1CnvMc/+o+Rd4gHjHe3AsgCgE0k2h6ElX7r/NutrAbfaDo7YvaWL2 H4ejVDZqRX9xyop8TOS2a0k2OqoGjbUh8fA/qCqaKr1eOx367jx6GwUKKYInh1aA50m/ fKDIsJo/Z3Ex23f0O4ipSgdQTB98mNjdH610xFcVBBmKtXVkNLTVoKdawvISUrp3oDml UHX2zHpuYRrSZUIXNG/ftzXxfQhyQDcrj8Yn5kpFc6PpThyRG8Uu7BViSU642lY/158v 7ktg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature:arc-authentication-results; bh=qqK1gxMbi0qpKQyupk94DOZnVj7K+di/XrkiHpeq3vs=; b=p4kEnxq20lxksF7392PZ5fzcuX7LgpQr/PS8tS6XFb+dFzeVrDpdttG4YbWfTTmViu zUvKEdQXozrhafjwbbr1BBj+hFjon+WYBvYfEV7236edEws4hXBcjBlrlt8nk4tiGPLk ySTONb6OHAhdhwR3ZquRz1nhgR62d5C2jMIguZeSR/7h+csXQFcE0Gq9cbfZc7QlIJpF Xw220wmm3JJEtvsiY/LHYbU33GxAZHvRmIK/j8YU8vVfyojyMF4TnEnh2lKRQErR3JMY xTevZSXJ/wA6QdaIx035wMfDVTEcvCoVQdHmsN5DmvznKsLayUQ6nshzYQRSc8ubWPx5 0v0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="av3oaI/P"; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b75-v6si7189522pfd.41.2018.06.28.06.33.17; Thu, 28 Jun 2018 06:33:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="av3oaI/P"; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965770AbeF1NdP (ORCPT + 9 others); Thu, 28 Jun 2018 09:33:15 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:50252 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbeF1NdN (ORCPT ); Thu, 28 Jun 2018 09:33:13 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id w5SDX54V115674; Thu, 28 Jun 2018 08:33:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1530192785; bh=qqK1gxMbi0qpKQyupk94DOZnVj7K+di/XrkiHpeq3vs=; h=From:To:CC:Subject:Date; b=av3oaI/PSosxE3uWn2/HjhJAlQ1vwd8zgs1aBHTqG7Z4fY5GN3Od7zHOePV12FXgM xOrp3NCFdeX6bbMDJqPlY8/wJXB6Px3nDkTNQce4QoiVAjB6nVz/3Va4i8n06xEqPo Czb5MJNPoAcmIkTYsA7A1lQ90GmBb9SRSbqATXtU= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w5SDX5LF030754; Thu, 28 Jun 2018 08:33:05 -0500 Received: from DLEE115.ent.ti.com (157.170.170.26) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 28 Jun 2018 08:33:05 -0500 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Thu, 28 Jun 2018 08:33:04 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w5SDX50m014960; Thu, 28 Jun 2018 08:33:05 -0500 Received: from localhost (a0272616local-lt.dhcp.ti.com [172.22.190.81]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id w5SDX4x11957; Thu, 28 Jun 2018 08:33:04 -0500 (CDT) From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH net v2] net: phy: DP83TC811: Fix diabling interrupts Date: Thu, 28 Jun 2018 08:32:53 -0500 Message-ID: <20180628133253.22871-1-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix a bug where INT_STAT1 was written twice and INT_STAT2 was ignored when disabling interrupts. Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy") Reviewed-by: Andrew Lunn Signed-off-by: Dan Murphy --- v2 - Updated commit message to add the Fixes - http://lists.openwall.net/netdev/2018/06/28/110 drivers/net/phy/dp83tc811.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0.582.gccdcbd54c diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c index 081d99aa3985..49ac678eb2dc 100644 --- a/drivers/net/phy/dp83tc811.c +++ b/drivers/net/phy/dp83tc811.c @@ -222,7 +222,7 @@ static int dp83811_config_intr(struct phy_device *phydev) if (err < 0) return err; - err = phy_write(phydev, MII_DP83811_INT_STAT1, 0); + err = phy_write(phydev, MII_DP83811_INT_STAT2, 0); } return err;