| Message ID | 1530200714-4504-12-git-send-email-vincent.guittot@linaro.org |
|---|---|
| State | Accepted |
| Commit | 5fd778915ad29184a5ff8eb82d1118f6916b79e4 |
| Headers | show |
| Series | track CPU utilization | expand |
On Thu, Jun 28, 2018 at 05:45:14PM +0200, Vincent Guittot wrote: > /proc/sys/kernel/sched_time_avg_ms entry is not used anywhere. > Remove it > > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Kees Cook <keescook@chromium.org> > Cc: "Luis R. Rodriguez" <mcgrof@kernel.org> > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> Reviewed-by: Luis R. Rodriguez <mcgrof@kernel.org> Luis
On Thu, 28 Jun 2018 at 21:03, Luis R. Rodriguez <mcgrof@kernel.org> wrote: > > On Thu, Jun 28, 2018 at 05:45:14PM +0200, Vincent Guittot wrote: > > /proc/sys/kernel/sched_time_avg_ms entry is not used anywhere. > > Remove it > > > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: Kees Cook <keescook@chromium.org> > > Cc: "Luis R. Rodriguez" <mcgrof@kernel.org> > > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> > > Reviewed-by: Luis R. Rodriguez <mcgrof@kernel.org> Thanks Vincent > > Luis
diff --git a/include/linux/sched/sysctl.h b/include/linux/sched/sysctl.h index 1c1a151..913488d 100644 --- a/include/linux/sched/sysctl.h +++ b/include/linux/sched/sysctl.h @@ -40,7 +40,6 @@ extern unsigned int sysctl_numa_balancing_scan_size; #ifdef CONFIG_SCHED_DEBUG extern __read_mostly unsigned int sysctl_sched_migration_cost; extern __read_mostly unsigned int sysctl_sched_nr_migrate; -extern __read_mostly unsigned int sysctl_sched_time_avg; int sched_proc_update_handler(struct ctl_table *table, int write, void __user *buffer, size_t *length, diff --git a/kernel/sched/core.c b/kernel/sched/core.c index e9aae7f..6935691 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -48,14 +48,6 @@ const_debug unsigned int sysctl_sched_features = const_debug unsigned int sysctl_sched_nr_migrate = 32; /* - * period over which we average the RT time consumption, measured - * in ms. - * - * default: 1s - */ -const_debug unsigned int sysctl_sched_time_avg = MSEC_PER_SEC; - -/* * period over which we measure -rt task CPU usage in us. * default: 1s */ diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index c71ea81..47b9175 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1706,7 +1706,6 @@ extern void deactivate_task(struct rq *rq, struct task_struct *p, int flags); extern void check_preempt_curr(struct rq *rq, struct task_struct *p, int flags); -extern const_debug unsigned int sysctl_sched_time_avg; extern const_debug unsigned int sysctl_sched_nr_migrate; extern const_debug unsigned int sysctl_sched_migration_cost; diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 2d9837c..f22f76b 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -368,14 +368,6 @@ static struct ctl_table kern_table[] = { .mode = 0644, .proc_handler = proc_dointvec, }, - { - .procname = "sched_time_avg_ms", - .data = &sysctl_sched_time_avg, - .maxlen = sizeof(unsigned int), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = &one, - }, #ifdef CONFIG_SCHEDSTATS { .procname = "sched_schedstats",
/proc/sys/kernel/sched_time_avg_ms entry is not used anywhere. Remove it Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Kees Cook <keescook@chromium.org> Cc: "Luis R. Rodriguez" <mcgrof@kernel.org> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> --- include/linux/sched/sysctl.h | 1 - kernel/sched/core.c | 8 -------- kernel/sched/sched.h | 1 - kernel/sysctl.c | 8 -------- 4 files changed, 18 deletions(-) -- 2.7.4