[v2] doc: dev-tools: kselftest.rst: update contributing new tests

Message ID 20180629125201.24025-1-anders.roxell@linaro.org
State New
Headers show
Series
  • [v2] doc: dev-tools: kselftest.rst: update contributing new tests
Related show

Commit Message

Anders Roxell June 29, 2018, 12:52 p.m.
Add a description that kernel config options should be added into a
config file that is placed next to the newly added test.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 Documentation/dev-tools/kselftest.rst | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.18.0

Comments

shuah June 29, 2018, 1:29 p.m. | #1
On 06/29/2018 06:52 AM, Anders Roxell wrote:
> Add a description that kernel config options should be added into a

> config file that is placed next to the newly added test.

> 

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---

>  Documentation/dev-tools/kselftest.rst | 5 +++++

>  1 file changed, 5 insertions(+)

> 

> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst

> index 3bf371a938d0..6f653acea248 100644

> --- a/Documentation/dev-tools/kselftest.rst

> +++ b/Documentation/dev-tools/kselftest.rst

> @@ -156,6 +156,11 @@ Contributing new tests (details)

>     installed by the distro on the system should be the primary focus to be able

>     to find regressions.

>  

> + * If a test needs specific kernel config options enabled, add a config file in

> +   the test directory to enable them.

> +

> +   e.g: tools/testing/selftests/android/ion/config

> +

>  Test Harness

>  ============

>  

>

Thanks. Looks good to me.

Reviewed-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>



thanks,
-- Shuah
Jonathan Corbet June 29, 2018, 3:02 p.m. | #2
On Fri, 29 Jun 2018 14:52:01 +0200
Anders Roxell <anders.roxell@linaro.org> wrote:

> Add a description that kernel config options should be added into a

> config file that is placed next to the newly added test.

> 

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>


Applied, thanks.

jon

Patch

diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
index 3bf371a938d0..6f653acea248 100644
--- a/Documentation/dev-tools/kselftest.rst
+++ b/Documentation/dev-tools/kselftest.rst
@@ -156,6 +156,11 @@  Contributing new tests (details)
    installed by the distro on the system should be the primary focus to be able
    to find regressions.
 
+ * If a test needs specific kernel config options enabled, add a config file in
+   the test directory to enable them.
+
+   e.g: tools/testing/selftests/android/ion/config
+
 Test Harness
 ============