| Message ID | 20180629150924.18197-4-jbrunet@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: es7134: driver updates | expand |
On Fri, Jun 29, 2018 at 05:09:22PM +0200, Jerome Brunet wrote: > Update the documentation to add support for the es7154 and > optional power supplies phandles. > +Optional properties: > +- VDD-supply: regulator phandle for the VDD supply > +- AVDD-supply: regulator phandle for the AVDD supply Unless the device is able to work with a power supply missing (which doesn't seem entirely credible) supply properties should never be optional.
On Mon, 2018-07-02 at 11:04 +0100, Mark Brown wrote: > On Fri, Jun 29, 2018 at 05:09:22PM +0200, Jerome Brunet wrote: > > Update the documentation to add support for the es7154 and > > optional power supplies phandles. > > +Optional properties: > > +- VDD-supply: regulator phandle for the VDD supply > > +- AVDD-supply: regulator phandle for the AVDD supply > > Unless the device is able to work with a power supply missing (which > doesn't seem entirely credible) supply properties should never be > optional. Sure the device cannot work without its physical supplies. I'll resubmit
diff --git a/Documentation/devicetree/bindings/sound/everest,es7134.txt b/Documentation/devicetree/bindings/sound/everest,es7134.txt index 5495a3cb8b7b..c6bcdc5bded8 100644 --- a/Documentation/devicetree/bindings/sound/everest,es7134.txt +++ b/Documentation/devicetree/bindings/sound/everest,es7134.txt @@ -1,7 +1,13 @@ ES7134 i2s DA converter Required properties: -- compatible : "everest,es7134" or "everest,es7144" +- compatible : "everest,es7134" or + "everest,es7144" or + "everest,es7154" + +Optional properties: +- VDD-supply: regulator phandle for the VDD supply +- AVDD-supply: regulator phandle for the AVDD supply Example:
Update the documentation to add support for the es7154 and optional power supplies phandles. Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> --- Documentation/devicetree/bindings/sound/everest,es7134.txt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.14.4