From patchwork Fri Jun 29 15:28:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 140603 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp985487ljj; Fri, 29 Jun 2018 08:28:56 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdGrQ0pHSfJPX8ozvhot0qMP00gEP60KvN7aA7BvjzwFSiGR3dbv6StLrmlddlfs98ZWKPX X-Received: by 2002:a62:c699:: with SMTP id x25-v6mr11154424pfk.16.1530286136499; Fri, 29 Jun 2018 08:28:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530286136; cv=none; d=google.com; s=arc-20160816; b=zsY4K4cuY1nny8jhHiVXbN4dmIsblQU8FhAyZDFEhMaxsFWtmyDfGkr1FaWOCQrcaR ABJIxNca4SiIVPjkriwRgbT2fvF6lX1m8xmWQUJYEf8hVQgHo3ALT0h2zHaKf0beQ2Vr pE1ylfRer9VmLdQc7WkM6xz9TtgXGgM69uMwhhIRPRl39uyqmP1A7eagxqvGs6AGsWvC uyv5tbUqBprwNeP71mP9x02BfpMCEO4T2RdCMYbiNwvZo5OISwQnJr/E2as+ZCAkEwTt RjyHqdNiNY+t7apVEvfQagL0Yp6IXJ33hGfF5P1mVJNanaoApuLOUFnOQYoX5FZPz0Ke Fu+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature:arc-authentication-results; bh=l4YipK+w/nEhXWi3fNi7UZAH3lTmWH5I62HygjmgKFc=; b=T94ARmN8K30TgX8tcwEYypGsvUCxVaGDqyIpQqO0Nrw2VXYUleePRm7kPmZmFBcJaL icu6i0TYW3e5uJV2pnKIEk8R5KtwxUR/Yct/Ey2y89TVmKEWiPPfRR++b4EmlkrFB+vL cA6BHxjd9pRFXWDLvi23h3STWVWT7FTzT5G7/FJFjRN9D9DBGNRad/d2ZSb+wRYjxiRR x0lLxmkhZYqQdSEEklAzfRXEfiPMB2wmtTbmcD6YSraTfw6pAgxBtdnlfd6HrHOzWDQG 25H/nNdrCLLzLqioAr3/oPmow58ofUgrwLCl1BsEzg61/EvGSjRAk5gWIFEX3Tc2M4/N tkMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=p7IGfKkf; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z18-v6si6567290pfl.209.2018.06.29.08.28.56; Fri, 29 Jun 2018 08:28:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=p7IGfKkf; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935562AbeF2P2x (ORCPT + 9 others); Fri, 29 Jun 2018 11:28:53 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36582 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934092AbeF2P2w (ORCPT ); Fri, 29 Jun 2018 11:28:52 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id w5TFSic5082325; Fri, 29 Jun 2018 10:28:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1530286124; bh=l4YipK+w/nEhXWi3fNi7UZAH3lTmWH5I62HygjmgKFc=; h=From:To:CC:Subject:Date; b=p7IGfKkfFuLEriAlsGjZHpcQ6RhSt1WGZ1ao7vJvkjxz6vFPNeyts+DGGgVbyEgVy mgFfO79nOZrcuGbF/71rOZkAyW5iT9/sJGuwZbF+6CrqGOQZZ3ZVRymUgnCIL5xYOX drIJyY18rcTjHooWzdLIhBZjg8NbPlTyJQ5qv5JE= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w5TFSitg007498; Fri, 29 Jun 2018 10:28:44 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 29 Jun 2018 10:28:44 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 29 Jun 2018 10:28:43 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w5TFSh8U016480; Fri, 29 Jun 2018 10:28:43 -0500 Received: from localhost (a0272616local-lt.dhcp.ti.com [172.22.149.121]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id w5TFShx17017; Fri, 29 Jun 2018 10:28:43 -0500 (CDT) From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH net v3] net: phy: DP83TC811: Fix disabling interrupts Date: Fri, 29 Jun 2018 10:28:31 -0500 Message-ID: <20180629152831.23259-1-dmurphy@ti.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix a bug where INT_STAT1 was written twice and INT_STAT2 was ignored when disabling interrupts. Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy") Reviewed-by: Andrew Lunn Signed-off-by: Dan Murphy --- v3 - Fix subject misspelling v2 - Updated commit message to add the Fixes - http://lists.openwall.net/netdev/2018/06/28/110 drivers/net/phy/dp83tc811.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0.582.gccdcbd54c diff --git a/drivers/net/phy/dp83tc811.c b/drivers/net/phy/dp83tc811.c index 081d99aa3985..49ac678eb2dc 100644 --- a/drivers/net/phy/dp83tc811.c +++ b/drivers/net/phy/dp83tc811.c @@ -222,7 +222,7 @@ static int dp83811_config_intr(struct phy_device *phydev) if (err < 0) return err; - err = phy_write(phydev, MII_DP83811_INT_STAT1, 0); + err = phy_write(phydev, MII_DP83811_INT_STAT2, 0); } return err;