[v4,2/6] dt: qcom: 8996: thermal: Move to DT initialisation

Message ID 80e54ddfa672ae05db24a90c5f5463fc7fcbec46.1530533998.git.amit.kucheria@linaro.org
State New
Headers show
Series
  • thermal: tsens: Refactoring for TSENSv2 IP
Related show

Commit Message

Amit Kucheria July 2, 2018, 12:44 p.m.
We also split up the regmap address space into two, one for the TM
registers, the other for the SROT registers. This was required to deal with
different address offsets for the TM and SROT registers across different
SoC families.

Since tsens-common.c/init_common() currently only registers one address
space, the order is important (TM before SROT). This is OK since the code
doesn't really use the SROT functionality yet.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Bjorn Andersson July 2, 2018, 6:48 p.m. | #1
On Mon 02 Jul 05:44 PDT 2018, Amit Kucheria wrote:

> We also split up the regmap address space into two, one for the TM

> registers, the other for the SROT registers. This was required to deal with

> different address offsets for the TM and SROT registers across different

> SoC families.

> 

> Since tsens-common.c/init_common() currently only registers one address

> space, the order is important (TM before SROT). This is OK since the code

> doesn't really use the SROT functionality yet.

> 

> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

> ---

>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 12 +++++++++++-

>  1 file changed, 11 insertions(+), 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi

> index 8c7f9ca..6c8a857 100644

> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi

> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi

> @@ -461,7 +461,17 @@

>  

>  		tsens0: thermal-sensor@4a8000 {

>  			compatible = "qcom,msm8996-tsens";

> -			reg = <0x4a8000 0x2000>;

> +			reg = <0x4a9000 0x1000>, /* TM */

> +			      <0x4a8000 0x1000>; /* SROT */

> +			#qcom,sensors = <13>;

> +			#thermal-sensor-cells = <1>;

> +		};

> +

> +		tsens1: thermal-sensor@4ac000 {

> +			compatible = "qcom,msm8996-tsens";

> +			reg = <0x4ad000 0x1000>, /* TM */

> +			      <0x4ac000 0x1000>; /* SROT */

> +			#qcom,sensors = <8>;

>  			#thermal-sensor-cells = <1>;

>  		};

>  

> -- 

> 2.7.4

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 8c7f9ca..6c8a857 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -461,7 +461,17 @@ 
 
 		tsens0: thermal-sensor@4a8000 {
 			compatible = "qcom,msm8996-tsens";
-			reg = <0x4a8000 0x2000>;
+			reg = <0x4a9000 0x1000>, /* TM */
+			      <0x4a8000 0x1000>; /* SROT */
+			#qcom,sensors = <13>;
+			#thermal-sensor-cells = <1>;
+		};
+
+		tsens1: thermal-sensor@4ac000 {
+			compatible = "qcom,msm8996-tsens";
+			reg = <0x4ad000 0x1000>, /* TM */
+			      <0x4ac000 0x1000>; /* SROT */
+			#qcom,sensors = <8>;
 			#thermal-sensor-cells = <1>;
 		};