[Xen-devel,v2,5/7] xen: Don't build libelf for Arm

Message ID 20180702161910.2013-6-julien.grall@arm.com
State Accepted
Commit ff3c5b1e60b865ca403d7d74a6c3bead6a1fa6f2
Headers show
Series
  • xen/arm: Shrink down Xen on Arm
Related show

Commit Message

Julien Grall July 2, 2018, 4:19 p.m.
Now that ELF support has been dropped to boot Dom0, no-one is using
libelf within the hypervisor.

Introduce a config option to select libelf on x86 and keep unselected
for Arm.

Signed-off-by: Julien Grall <julien.grall@arm.com>

---
    Changes in v2:
        - Rename HAS_ELF to NEEDS_LIBELF
---
 xen/arch/x86/Kconfig | 1 +
 xen/common/Kconfig   | 3 +++
 xen/common/Makefile  | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

Comments

Jan Beulich July 3, 2018, 7:39 a.m. | #1
>>> On 02.07.18 at 18:19, <julien.grall@arm.com> wrote:
> Now that ELF support has been dropped to boot Dom0, no-one is using
> libelf within the hypervisor.
> 
> Introduce a config option to select libelf on x86 and keep unselected
> for Arm.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
Stefano Stabellini July 11, 2018, 7:16 p.m. | #2
On Mon, 2 Jul 2018, Julien Grall wrote:
> Now that ELF support has been dropped to boot Dom0, no-one is using
> libelf within the hypervisor.
> 
> Introduce a config option to select libelf on x86 and keep unselected
> for Arm.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
>     Changes in v2:
>         - Rename HAS_ELF to NEEDS_LIBELF
> ---
>  xen/arch/x86/Kconfig | 1 +
>  xen/common/Kconfig   | 3 +++
>  xen/common/Makefile  | 2 +-
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> index f64fc56739..c75f0526d8 100644
> --- a/xen/arch/x86/Kconfig
> +++ b/xen/arch/x86/Kconfig
> @@ -24,6 +24,7 @@ config X86
>  	select HAS_PDX
>  	select HAS_UBSAN
>  	select HAS_VPCI if !PV_SHIM_EXCLUSIVE
> +	select NEEDS_LIBELF
>  	select NUMA
>  
>  config ARCH_DEFCONFIG
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 9043dce937..d4c0951a24 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -44,6 +44,9 @@ config HAS_GDBSX
>  config HAS_IOPORTS
>  	bool
>  
> +config NEEDS_LIBELF
> +	bool
> +
>  config NEEDS_LIST_SORT
>  	bool
>  
> diff --git a/xen/common/Makefile b/xen/common/Makefile
> index 24d4752ccc..b3e0b0ebf4 100644
> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -78,5 +78,5 @@ obj-$(CONFIG_TMEM) += $(tmem-y)
>  subdir-$(CONFIG_COVERAGE) += coverage
>  subdir-$(CONFIG_UBSAN) += ubsan
>  
> -subdir-y += libelf
> +subdir-$(CONFIG_NEEDS_LIBELF) += libelf
>  subdir-$(CONFIG_HAS_DEVICE_TREE) += libfdt
> -- 
> 2.11.0
>

Patch

diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
index f64fc56739..c75f0526d8 100644
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -24,6 +24,7 @@  config X86
 	select HAS_PDX
 	select HAS_UBSAN
 	select HAS_VPCI if !PV_SHIM_EXCLUSIVE
+	select NEEDS_LIBELF
 	select NUMA
 
 config ARCH_DEFCONFIG
diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 9043dce937..d4c0951a24 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -44,6 +44,9 @@  config HAS_GDBSX
 config HAS_IOPORTS
 	bool
 
+config NEEDS_LIBELF
+	bool
+
 config NEEDS_LIST_SORT
 	bool
 
diff --git a/xen/common/Makefile b/xen/common/Makefile
index 24d4752ccc..b3e0b0ebf4 100644
--- a/xen/common/Makefile
+++ b/xen/common/Makefile
@@ -78,5 +78,5 @@  obj-$(CONFIG_TMEM) += $(tmem-y)
 subdir-$(CONFIG_COVERAGE) += coverage
 subdir-$(CONFIG_UBSAN) += ubsan
 
-subdir-y += libelf
+subdir-$(CONFIG_NEEDS_LIBELF) += libelf
 subdir-$(CONFIG_HAS_DEVICE_TREE) += libfdt