[v2,2/2] arm: qemu-arm: enable PL031 (RTC) in defconfig

Message ID 20180704073628.23596-3-takahiro.akashi@linaro.org
State New
Headers show
Series
  • arm: qemu-arm: enable PL031 (RTC)
Related show

Commit Message

AKASHI Takahiro July 4, 2018, 7:36 a.m.
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 configs/qemu_arm64_defconfig | 2 ++
 configs/qemu_arm_defconfig   | 2 ++
 2 files changed, 4 insertions(+)

Comments

Alexander Graf July 4, 2018, 8:56 a.m. | #1
On 07/04/2018 09:36 AM, AKASHI Takahiro wrote:
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>   configs/qemu_arm64_defconfig | 2 ++
>   configs/qemu_arm_defconfig   | 2 ++
>   2 files changed, 4 insertions(+)
>
> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
> index cdf5072fe4..f3e3963860 100644
> --- a/configs/qemu_arm64_defconfig
> +++ b/configs/qemu_arm64_defconfig
> @@ -28,3 +28,5 @@ CONFIG_USB=y
>   CONFIG_DM_USB=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_USB_EHCI_PCI=y
> +CONFIG_DM_RTC=y
> +CONFIG_RTC_PL031=y

Is there any particular reason you don't just do select statements in 
the ARCH_QEMU definition? Or maybe imply?


Alex

> diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
> index bbce6cd719..28dfba0283 100644
> --- a/configs/qemu_arm_defconfig
> +++ b/configs/qemu_arm_defconfig
> @@ -28,3 +28,5 @@ CONFIG_USB=y
>   CONFIG_DM_USB=y
>   CONFIG_USB_EHCI_HCD=y
>   CONFIG_USB_EHCI_PCI=y
> +CONFIG_DM_RTC=y
> +CONFIG_RTC_PL031=y
Heinrich Schuchardt July 4, 2018, 10:25 a.m. | #2
On 07/04/2018 10:56 AM, Alexander Graf wrote:
> On 07/04/2018 09:36 AM, AKASHI Takahiro wrote:
>> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>> ---
>>   configs/qemu_arm64_defconfig | 2 ++
>>   configs/qemu_arm_defconfig   | 2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
>> index cdf5072fe4..f3e3963860 100644
>> --- a/configs/qemu_arm64_defconfig
>> +++ b/configs/qemu_arm64_defconfig
>> @@ -28,3 +28,5 @@ CONFIG_USB=y
>>   CONFIG_DM_USB=y
>>   CONFIG_USB_EHCI_HCD=y
>>   CONFIG_USB_EHCI_PCI=y
>> +CONFIG_DM_RTC=y
>> +CONFIG_RTC_PL031=y
> 
> Is there any particular reason you don't just do select statements in
> the ARCH_QEMU definition? Or maybe imply?

'select' makes it impossible to switch configuration options off. We
should only use it if really needed. 'imply' is fine here.

Configuration options should appear in *_defconfig files in the same
sequence as in the generated .config file. CONFIG_RTC_PL031 precedes
CONFIG_SCSI.

Please, add a commit message to the next version of the patch.

Best regards

Heinrich

> 
> 
> Alex
> 
>> diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
>> index bbce6cd719..28dfba0283 100644
>> --- a/configs/qemu_arm_defconfig
>> +++ b/configs/qemu_arm_defconfig
>> @@ -28,3 +28,5 @@ CONFIG_USB=y
>>   CONFIG_DM_USB=y
>>   CONFIG_USB_EHCI_HCD=y
>>   CONFIG_USB_EHCI_PCI=y
>> +CONFIG_DM_RTC=y
>> +CONFIG_RTC_PL031=y
> 
> 
>
AKASHI Takahiro July 5, 2018, 6:59 a.m. | #3
On Wed, Jul 04, 2018 at 12:25:34PM +0200, Heinrich Schuchardt wrote:
> On 07/04/2018 10:56 AM, Alexander Graf wrote:
> > On 07/04/2018 09:36 AM, AKASHI Takahiro wrote:
> >> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> >> ---
> >>   configs/qemu_arm64_defconfig | 2 ++
> >>   configs/qemu_arm_defconfig   | 2 ++
> >>   2 files changed, 4 insertions(+)
> >>
> >> diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
> >> index cdf5072fe4..f3e3963860 100644
> >> --- a/configs/qemu_arm64_defconfig
> >> +++ b/configs/qemu_arm64_defconfig
> >> @@ -28,3 +28,5 @@ CONFIG_USB=y
> >>   CONFIG_DM_USB=y
> >>   CONFIG_USB_EHCI_HCD=y
> >>   CONFIG_USB_EHCI_PCI=y
> >> +CONFIG_DM_RTC=y
> >> +CONFIG_RTC_PL031=y
> > 
> > Is there any particular reason you don't just do select statements in
> > the ARCH_QEMU definition? Or maybe imply?
> 
> 'select' makes it impossible to switch configuration options off. We
> should only use it if really needed. 'imply' is fine here.

Basically I don't care whether those two go into defconfig or ARCH_QEMU,
but as far as RTC_PL031 is concerned, it always comes with qemu's VM and
"selecting" it at ARCH_QEMU is quite reasonable.
Turning off this option only saves hundreds of bytes for VM. Who cares?

That's said, we will go for 'imply.'

For CMD_DATE, it will be automatically turned on if DM_RTC.

To make RTC_PL031 independent from CMD_DATE, we also have to
modify rtc/date.c's dependency (DM_RTC).

> Configuration options should appear in *_defconfig files in the same
> sequence as in the generated .config file. CONFIG_RTC_PL031 precedes
> CONFIG_SCSI.

So they will go away from *_defconfig.

Thanks,
-Takahiro AKASHI

> Please, add a commit message to the next version of the patch.
> 
> Best regards
> 
> Heinrich
> 
> > 
> > 
> > Alex
> > 
> >> diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
> >> index bbce6cd719..28dfba0283 100644
> >> --- a/configs/qemu_arm_defconfig
> >> +++ b/configs/qemu_arm_defconfig
> >> @@ -28,3 +28,5 @@ CONFIG_USB=y
> >>   CONFIG_DM_USB=y
> >>   CONFIG_USB_EHCI_HCD=y
> >>   CONFIG_USB_EHCI_PCI=y
> >> +CONFIG_DM_RTC=y
> >> +CONFIG_RTC_PL031=y
> > 
> > 
> > 
>

Patch

diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig
index cdf5072fe4..f3e3963860 100644
--- a/configs/qemu_arm64_defconfig
+++ b/configs/qemu_arm64_defconfig
@@ -28,3 +28,5 @@  CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
+CONFIG_DM_RTC=y
+CONFIG_RTC_PL031=y
diff --git a/configs/qemu_arm_defconfig b/configs/qemu_arm_defconfig
index bbce6cd719..28dfba0283 100644
--- a/configs/qemu_arm_defconfig
+++ b/configs/qemu_arm_defconfig
@@ -28,3 +28,5 @@  CONFIG_USB=y
 CONFIG_DM_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_PCI=y
+CONFIG_DM_RTC=y
+CONFIG_RTC_PL031=y