From patchwork Wed Jul 4 14:42:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 141071 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp887260ljj; Wed, 4 Jul 2018 07:43:04 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeDZkz9RDSP5lR+g74i6K8sut5UJ1rPEDWZBYCS+0dwyewBpJdJKrV9+rCpkrGNqKsxAl9B X-Received: by 2002:adf:a963:: with SMTP id u90-v6mr1980968wrc.248.1530715384833; Wed, 04 Jul 2018 07:43:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530715384; cv=none; d=google.com; s=arc-20160816; b=BNNfsRcPDf+dKqRC7TNaXFjfOaZkqoUDpGAq7ZXaARwkUDFuFXaCJBwQHFcuHxHmoB tEzmjnw7WB0gQi3Fnaw0I29nPIFW4TmRSdv/7/xuN3NUBhPoSRY7UM0u2HbgCSFrwSpw CusBgKgzDOVffr04uhVu5SbK1G9yTtov8dZFZ19eWJQN8NbMCFXk/yIxt0PbZ/E37vlL +Isx0ZfN02oXPXcDFz35//BBx+KXIxmpA2lUgSGAOFncY8xwXSYYpKjAFpmE0R3bsLg2 xitdZg9/4+g8EGVpQ//qSv7/GfPzEDmyRKk6SXpjplfzTBAIbnKAzuTcmyMvkIfJc2FN 521w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=FJ6OXGrP7K7PXawTRkemSUNdLSbgE2XF74LC10pryHM=; b=NzbD6LvqKOnDRDQpZYdw2dEtnD+EZ5I/aLV3WV3/yHKqgho9aKm/jL2qd5/vqHKPRV EbNlP7IRnLFUCw80oUIMsy1/cayIA8nmwDAqIIFbo0QwTMBPMGzLPCd+jw3hJpkl+Vip 8JuGtp0bETbcilaYZ8zvVrgOWEDAFOsI/kU+ct9o8B920vhOAI8plZNUVPVVUwJkKXPe bMnbPc+i13fZrQUI9M+siq/ccDtlvU2v/c44jINFBDFZsjTb5a/zhp3BGFUqJinMT0fD CLeFHuT3sQFy2eUJzAAnMjrNe4l17LS6PTnkcZIFxMfRoY6KsFbkiXNfWlcU33m8s3KA 2ylQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ruRrHl6P; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id a64-v6si2928893wmf.75.2018.07.04.07.43.04; Wed, 04 Jul 2018 07:43:04 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ruRrHl6P; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id DD7452677C1; Wed, 4 Jul 2018 16:42:27 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B5ADD2677B0; Wed, 4 Jul 2018 16:42:23 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D7EE22677A5 for ; Wed, 4 Jul 2018 16:42:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=fR98dmWnEUjkeRh71LR9nuOqdqAlj6JzVrMd/OCBtSg=; b=ruRrHl6PMgQo nzaUwAeSvMDnqgXMWsKreRLdcfPrCgjtY9PbWXPB+bBjnSQe3RWVgTVUAUBYxcsxGhLfqb5PaBEme 0q1M0jXB9lT8l4bDFa6EU4xQbAFSOhpZWFYNT7pjy2X0LgHw/oGoVdJCeE0AT+IzAf8kH3jsC1W6s Jhvhg=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1faiyz-00074W-VE; Wed, 04 Jul 2018 14:42:14 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1faiyz-00044f-HH; Wed, 04 Jul 2018 15:42:13 +0100 From: Mark Brown To: Gustavo A. R. Silva In-Reply-To: <20180704142828.GA11007@embeddedor.com> Message-Id: Date: Wed, 04 Jul 2018 15:42:13 +0100 Cc: alsa-devel@alsa-project.org, Liam Girdwood , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown Subject: [alsa-devel] Applied "ASoC: nau8825: use 64-bit arithmetic instead of 32-bit" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: nau8825: use 64-bit arithmetic instead of 32-bit has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From da13ed1d80fe6a4d95043aaf2e0aff292ade5708 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Wed, 4 Jul 2018 09:28:28 -0500 Subject: [PATCH] ASoC: nau8825: use 64-bit arithmetic instead of 32-bit Add suffix ULL to constant 256 in order to give the compiler complete information about the proper arithmetic to use. Notice that such constant is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit arithmetic: 256 * fs * 2 * mclk_src_scaling[i].param Addresses-Coverity-ID: 1339616 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- sound/soc/codecs/nau8825.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c index dc6ea4987b7d..b9fed99d8b5e 100644 --- a/sound/soc/codecs/nau8825.c +++ b/sound/soc/codecs/nau8825.c @@ -2016,7 +2016,7 @@ static int nau8825_calc_fll_param(unsigned int fll_in, unsigned int fs, fvco_max = 0; fvco_sel = ARRAY_SIZE(mclk_src_scaling); for (i = 0; i < ARRAY_SIZE(mclk_src_scaling); i++) { - fvco = 256 * fs * 2 * mclk_src_scaling[i].param; + fvco = 256ULL * fs * 2 * mclk_src_scaling[i].param; if (fvco > NAU_FVCO_MIN && fvco < NAU_FVCO_MAX && fvco_max < fvco) { fvco_max = fvco;