[2/2] arm64: dts: hi6220: Add all CPUs in cooling maps

Message ID fd741a8140809406ce86c479bbf6f03319490a64.1530766981.git.viresh.kumar@linaro.org
State New
Headers show
Series
  • dt: thermal: Fix broken cooling-maps
Related show

Commit Message

Viresh Kumar July 5, 2018, 5:09 a.m.
Each CPU can (and does) participate in cooling down the system but the
DT only captures the CPU0 in the cooling maps. Things work by chance as
under normal circumstances its the CPU0 which is used by the operating
systems to probe the cooling devices. But as soon as that ordering
changes and any other CPU is used to bring up the cooling device, we
will start seeing errors.

On the other hand, the hardware is partially defined in DT in these
cases and we must do a better job by capturing all devices.

Add all devices (CPUs here) in the cooling maps which are also affected
by the trip point.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.18.0.rc1.242.g61856ae69a2c

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Daniel Lezcano July 5, 2018, 8:44 a.m. | #1
On 05/07/2018 07:09, Viresh Kumar wrote:
> Each CPU can (and does) participate in cooling down the system but the

> DT only captures the CPU0 in the cooling maps. Things work by chance as

> under normal circumstances its the CPU0 which is used by the operating

> systems to probe the cooling devices. But as soon as that ordering

> changes and any other CPU is used to bring up the cooling device, we

> will start seeing errors.

> 

> On the other hand, the hardware is partially defined in DT in these

> cases and we must do a better job by capturing all devices.

> 

> Add all devices (CPUs here) in the cooling maps which are also affected

> by the trip point.

> 

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>


Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>


> ---

>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++-

>  1 file changed, 8 insertions(+), 1 deletion(-)

> 

> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi

> index 247024df714f..919d36b91bf3 100644

> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi

> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi

> @@ -886,7 +886,14 @@

>  				cooling-maps {

>  					map0 {

>  						trip = <&target>;

> -						cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;

> +						cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,

> +								 <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;

>  					};

>  				};

>  			};

> 



-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 247024df714f..919d36b91bf3 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -886,7 +886,14 @@ 
 				cooling-maps {
 					map0 {
 						trip = <&target>;
-						cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+						cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+								 <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
 					};
 				};
 			};