[v5,09/27] venus: hfi_venus: move set of default properties to core init

Message ID 20180705130401.24315-10-stanimir.varbanov@linaro.org
State New
Headers show
  • Untitled series #12880
Related show

Commit Message

Stanimir Varbanov July 5, 2018, 1:03 p.m.
This moves setting of default properties (firmware debug, idle
indicator and low power mode) from session init to core init.
All of those properties are need to be enabled/disabled early
so that they could be used before the clients are even initialized.

The other reason is to set idle indicator property early before
we enter into venus_suspend function where we need to check for

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

Reviewed-by: Tomasz Figa <tfiga@chromium.org>

 drivers/media/platform/qcom/venus/hfi_venus.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)



diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
index 72a8547eab39..7a83e967a8ea 100644
--- a/drivers/media/platform/qcom/venus/hfi_venus.c
+++ b/drivers/media/platform/qcom/venus/hfi_venus.c
@@ -1091,6 +1091,10 @@  static int venus_core_init(struct venus_core *core)
 	if (ret)
 		dev_warn(dev, "failed to send image version pkt to fw\n");
+	ret = venus_sys_set_default_properties(hdev);
+	if (ret)
+		return ret;
 	return 0;
@@ -1135,10 +1139,6 @@  static int venus_session_init(struct venus_inst *inst, u32 session_type,
 	struct hfi_session_init_pkt pkt;
 	int ret;
-	ret = venus_sys_set_default_properties(hdev);
-	if (ret)
-		return ret;
 	ret = pkt_session_init(&pkt, inst, session_type, codec);
 	if (ret)
 		goto err;