From patchwork Thu Jul 5 17:07:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 141224 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2179964ljj; Thu, 5 Jul 2018 10:08:30 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc4e0ontpUS4qCPpK4IyrmnuajloxKhUtTw5+z4E8n9pDrZEvnR+KiONkYXSrkHZEe3910t X-Received: by 2002:adf:f5c3:: with SMTP id k3-v6mr5006573wrp.219.1530810510810; Thu, 05 Jul 2018 10:08:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530810510; cv=none; d=google.com; s=arc-20160816; b=S3J7/EIfVa2HLAXV4xQLwDb05Z9Z4AloGo/ikhglyo2daQFtR6fslo7uxKBATRS0qh nZYarSO2pDgElddXQavM93EMDPQ6t2jnlD02h6D36bRPwfhTgugZMNPo9mirDLRD0KZ1 O2eeGzW8lptwdPumjPeNxgE8Ae3bM4X2u6eeOEuK43jWM/gHKcTXs7Z9SUjIeT2jpyop LF3X8hdwgH39zmreA1auk0Eq+s0c1PpzmR4BpAHRfPL4ITaNQVoy44RPD7jrwOUeoQYZ 16xciR5khE1yCIyEfBunlzDvWimkUMinLEY7CDurKthbr76Bb28WHiLTHWICbdInCq1/ Hdgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=0O9rSdQor+pUWVzsdqf3lHk6cZoGUpZDB3xdpOgALVE=; b=m8yRFbNNDzN3Xo32UL5teGDWYs9leDwuF6CGuR4hpewhpeA77qL/A/c4AnCBHF0MdM M5y0tn1FtzX6XUQDHCEifi02jjMLCzRYj1XKeCoLWwoPgQZcRtuiFlT6gd+K4CahrZU0 8dvy7d4aoA9wVWUXi4tlHXcgRjxjVMnY3mcq92/54mbc0hrcTVwlTYrY2E8jBHGxWlmi GwuIMbiXpbZdJrlbq/SOuGUTHoWQHv4i2xKLUa/kNQvfqUqH0vFADc2n+2nPpBC6myYq m4aP/UAEeUB3XXLQWmgXaYWsKNOA2Wrm2vnj2gYm3/qBB1TIwgLFrMfb1z6U5wGvYupN Zolw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=dl0odOMN; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id l1-v6si5969575wri.191.2018.07.05.10.08.30; Thu, 05 Jul 2018 10:08:30 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=dl0odOMN; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 80F7626761D; Thu, 5 Jul 2018 19:08:29 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 52AB8267650; Thu, 5 Jul 2018 19:08:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id A4B24267601 for ; Thu, 5 Jul 2018 19:08:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=QBX7q0z7a0MfRjVPgH49NGLc90tgKHBnBur26Tkp7oY=; b=dl0odOMNy9ca qkuMERl0CxilL5o5BAqlCJh3k9c12YqSNefmCN+X6HlWPPIWEE41afxT8XU4rHPn/9A1+cQL13Ehv aIuv8tk+rwZtcO86CEyGOm1RzvV7P4S8Rki+DmUVCN/AxjLKW0WlAA9B/URfXDHyEzLkT1sIQ+2ij 1gs+8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fb7jb-00010i-EJ; Thu, 05 Jul 2018 17:07:59 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fb7ja-00008q-KN; Thu, 05 Jul 2018 18:07:58 +0100 From: Mark Brown To: Gustavo A. R. Silva In-Reply-To: <20180705130617.GA31233@embeddedor.com> Message-Id: Date: Thu, 05 Jul 2018 18:07:58 +0100 Cc: alsa-devel@alsa-project.org, Liam Girdwood , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown Subject: [alsa-devel] Applied "ASoC: nau8824: use 64-bit arithmetic instead of 32-bit" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: nau8824: use 64-bit arithmetic instead of 32-bit has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From f7ddff54d0a0f068442414b48bec7f22aa777de7 Mon Sep 17 00:00:00 2001 From: "Gustavo A. R. Silva" Date: Thu, 5 Jul 2018 08:06:17 -0500 Subject: [PATCH] ASoC: nau8824: use 64-bit arithmetic instead of 32-bit Add suffix ULL to constant 256 in order to give the compiler complete information about the proper arithmetic to use. Notice that such constant is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit arithmetic: 256 * fs * 2 * mclk_src_scaling[i].param Addresses-Coverity-ID: 1432039 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Mark Brown --- sound/soc/codecs/nau8824.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.18.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 6bd14453f06e..468d5143e2c4 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1274,7 +1274,7 @@ static int nau8824_calc_fll_param(unsigned int fll_in, fvco_max = 0; fvco_sel = ARRAY_SIZE(mclk_src_scaling); for (i = 0; i < ARRAY_SIZE(mclk_src_scaling); i++) { - fvco = 256 * fs * 2 * mclk_src_scaling[i].param; + fvco = 256ULL * fs * 2 * mclk_src_scaling[i].param; if (fvco > NAU_FVCO_MIN && fvco < NAU_FVCO_MAX && fvco_max < fvco) { fvco_max = fvco;