[for,3.0,01/10] tests/.gitignore: don't ignore docker tests

Message ID 20180709152117.21585-2-alex.bennee@linaro.org
State Superseded
Headers show
Series
  • various docker fixes
Related show

Commit Message

Alex Bennée July 9, 2018, 3:21 p.m.
This was being a little over enthusiastic hiding files.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/.gitignore | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

Comments

Fam Zheng July 10, 2018, 6:57 a.m. | #1
On Mon, 07/09 16:21, Alex Bennée wrote:
> This was being a little over enthusiastic hiding files.


What is "this" that hides test-* and calls for this patch?

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/.gitignore | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/tests/.gitignore b/tests/.gitignore

> index 08e2df1ce1..72c18aaab0 100644

> --- a/tests/.gitignore

> +++ b/tests/.gitignore

> @@ -9,6 +9,7 @@ qht-bench

>  rcutorture

>  test-*

>  !test-*.c

> +!docker/test-*

>  test-qapi-commands.[ch]

>  test-qapi-events.[ch]

>  test-qapi-types.[ch]

> -- 

> 2.17.1

>
Alex Bennée July 10, 2018, 7:54 a.m. | #2
Fam Zheng <famz@redhat.com> writes:

> On Mon, 07/09 16:21, Alex Bennée wrote:

>> This was being a little over enthusiastic hiding files.

>

> What is "this" that hides test-* and calls for this patch?


I thought that was implicit from the first line, this is the .gitignore.

>

>>

>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>> ---

>>  tests/.gitignore | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/tests/.gitignore b/tests/.gitignore

>> index 08e2df1ce1..72c18aaab0 100644

>> --- a/tests/.gitignore

>> +++ b/tests/.gitignore

>> @@ -9,6 +9,7 @@ qht-bench

>>  rcutorture

>>  test-*

>>  !test-*.c

>> +!docker/test-*

>>  test-qapi-commands.[ch]

>>  test-qapi-events.[ch]

>>  test-qapi-types.[ch]

>> --

>> 2.17.1

>>



--
Alex Bennée
Fam Zheng July 10, 2018, 8:36 a.m. | #3
On Tue, 07/10 08:54, Alex Bennée wrote:
> 

> Fam Zheng <famz@redhat.com> writes:

> 

> > On Mon, 07/09 16:21, Alex Bennée wrote:

> >> This was being a little over enthusiastic hiding files.

> >

> > What is "this" that hides test-* and calls for this patch?

> 

> I thought that was implicit from the first line, this is the .gitignore.


Indeed you're right. Maybe that line should be more specific, but I have no
strong opinion.

Fam

> 

> >

> >>

> >> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> >> ---

> >>  tests/.gitignore | 1 +

> >>  1 file changed, 1 insertion(+)

> >>

> >> diff --git a/tests/.gitignore b/tests/.gitignore

> >> index 08e2df1ce1..72c18aaab0 100644

> >> --- a/tests/.gitignore

> >> +++ b/tests/.gitignore

> >> @@ -9,6 +9,7 @@ qht-bench

> >>  rcutorture

> >>  test-*

> >>  !test-*.c

> >> +!docker/test-*

> >>  test-qapi-commands.[ch]

> >>  test-qapi-events.[ch]

> >>  test-qapi-types.[ch]

> >> --

> >> 2.17.1

> >>

> 

> 

> --

> Alex Bennée
Philippe Mathieu-Daudé July 10, 2018, 8:50 p.m. | #4
On 07/09/2018 12:21 PM, Alex Bennée wrote:
> This was being a little over enthusiastic hiding files.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> ---

>  tests/.gitignore | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/tests/.gitignore b/tests/.gitignore

> index 08e2df1ce1..72c18aaab0 100644

> --- a/tests/.gitignore

> +++ b/tests/.gitignore

> @@ -9,6 +9,7 @@ qht-bench

>  rcutorture

>  test-*

>  !test-*.c

> +!docker/test-*

>  test-qapi-commands.[ch]

>  test-qapi-events.[ch]

>  test-qapi-types.[ch]

>

Patch

diff --git a/tests/.gitignore b/tests/.gitignore
index 08e2df1ce1..72c18aaab0 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -9,6 +9,7 @@  qht-bench
 rcutorture
 test-*
 !test-*.c
+!docker/test-*
 test-qapi-commands.[ch]
 test-qapi-events.[ch]
 test-qapi-types.[ch]