extcon: max3355: include mod_devicetable.h

Message ID 20180711155039.3600663-1-arnd@arndb.de
State New
Headers show
Series
  • extcon: max3355: include mod_devicetable.h
Related show

Commit Message

Arnd Bergmann July 11, 2018, 3:50 p.m.
Another driver turned up that is missing linux/mod_devicetable.h after
the device IDs are split out from linux/platform_device.h:

drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'
 static const struct of_device_id max3355_match_table[] = {

Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
Greg, please add that to the char-misc tree that already has
other related patches.
---
 drivers/extcon/extcon-max3355.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0

Comments

Chanwoo Choi July 12, 2018, 1:30 a.m. | #1
On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
> Another driver turned up that is missing linux/mod_devicetable.h after

> the device IDs are split out from linux/platform_device.h:

> 

> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'

>  static const struct of_device_id max3355_match_table[] = {

> 

> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

> Greg, please add that to the char-misc tree that already has

> other related patches.

> ---

>  drivers/extcon/extcon-max3355.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c

> index 0aa410836f4e..1335a476bfec 100644

> --- a/drivers/extcon/extcon-max3355.c

> +++ b/drivers/extcon/extcon-max3355.c

> @@ -14,6 +14,7 @@

>  #include <linux/gpio/consumer.h>

>  #include <linux/interrupt.h>

>  #include <linux/module.h>

> +#include <linux/mod_devicetable.h>

>  #include <linux/platform_device.h>

>  

>  struct max3355_data {

> 


Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
Chanwoo Choi July 12, 2018, 1:31 a.m. | #2
On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> On 2018년 07월 12일 00:50, Arnd Bergmann wrote:

>> Another driver turned up that is missing linux/mod_devicetable.h after

>> the device IDs are split out from linux/platform_device.h:

>>

>> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'

>>  static const struct of_device_id max3355_match_table[] = {

>>

>> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")

>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>> ---

>> Greg, please add that to the char-misc tree that already has

>> other related patches.

>> ---

>>  drivers/extcon/extcon-max3355.c | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c

>> index 0aa410836f4e..1335a476bfec 100644

>> --- a/drivers/extcon/extcon-max3355.c

>> +++ b/drivers/extcon/extcon-max3355.c

>> @@ -14,6 +14,7 @@

>>  #include <linux/gpio/consumer.h>

>>  #include <linux/interrupt.h>

>>  #include <linux/module.h>

>> +#include <linux/mod_devicetable.h>

>>  #include <linux/platform_device.h>

>>  

>>  struct max3355_data {

>>

> 

> Applied it. Thanks.

> 


If Greg pick up this patch, I'll drop it from extcon git.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
Randy Dunlap July 12, 2018, 2:26 a.m. | #3
On 07/11/2018 08:50 AM, Arnd Bergmann wrote:
> Another driver turned up that is missing linux/mod_devicetable.h after

> the device IDs are split out from linux/platform_device.h:

> 

> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'

>  static const struct of_device_id max3355_match_table[] = {

> 

> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Sorry for the delay.  I've been traveling.
And Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---

> Greg, please add that to the char-misc tree that already has

> other related patches.

> ---

>  drivers/extcon/extcon-max3355.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c

> index 0aa410836f4e..1335a476bfec 100644

> --- a/drivers/extcon/extcon-max3355.c

> +++ b/drivers/extcon/extcon-max3355.c

> @@ -14,6 +14,7 @@

>  #include <linux/gpio/consumer.h>

>  #include <linux/interrupt.h>

>  #include <linux/module.h>

> +#include <linux/mod_devicetable.h>

>  #include <linux/platform_device.h>

>  

>  struct max3355_data {

> 



-- 
~Randy
Greg Kroah-Hartman July 12, 2018, 6:11 a.m. | #4
On Thu, Jul 12, 2018 at 10:31:45AM +0900, Chanwoo Choi wrote:
> On 2018년 07월 12일 10:30, Chanwoo Choi wrote:

> > On 2018년 07월 12일 00:50, Arnd Bergmann wrote:

> >> Another driver turned up that is missing linux/mod_devicetable.h after

> >> the device IDs are split out from linux/platform_device.h:

> >>

> >> drivers/extcon/extcon-max3355.c:127:34: error: array type has incomplete element type 'struct of_device_id'

> >>  static const struct of_device_id max3355_match_table[] = {

> >>

> >> Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h")

> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> >> ---

> >> Greg, please add that to the char-misc tree that already has

> >> other related patches.

> >> ---

> >>  drivers/extcon/extcon-max3355.c | 1 +

> >>  1 file changed, 1 insertion(+)

> >>

> >> diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c

> >> index 0aa410836f4e..1335a476bfec 100644

> >> --- a/drivers/extcon/extcon-max3355.c

> >> +++ b/drivers/extcon/extcon-max3355.c

> >> @@ -14,6 +14,7 @@

> >>  #include <linux/gpio/consumer.h>

> >>  #include <linux/interrupt.h>

> >>  #include <linux/module.h>

> >> +#include <linux/mod_devicetable.h>

> >>  #include <linux/platform_device.h>

> >>  

> >>  struct max3355_data {

> >>

> > 

> > Applied it. Thanks.

> > 

> 

> If Greg pick up this patch, I'll drop it from extcon git.


Greg picked it up already :)

thanks,

greg k-h

Patch

diff --git a/drivers/extcon/extcon-max3355.c b/drivers/extcon/extcon-max3355.c
index 0aa410836f4e..1335a476bfec 100644
--- a/drivers/extcon/extcon-max3355.c
+++ b/drivers/extcon/extcon-max3355.c
@@ -14,6 +14,7 @@ 
 #include <linux/gpio/consumer.h>
 #include <linux/interrupt.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>
 
 struct max3355_data {