kbuild: suppress warnings from 'getconf LFS_*'

Message ID 1531391916-24086-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 6d79a7b424a5630a6fcab31fd7c38af4ea9c9a0f
Headers show
Series
  • kbuild: suppress warnings from 'getconf LFS_*'
Related show

Commit Message

Masahiro Yamada July 12, 2018, 10:38 a.m.
Suppress warnings for systems that do not recognize LFS_*.

 getconf: no such configuration parameter `LFS_CFLAGS'
 getconf: no such configuration parameter `LFS_LDFLAGS'
 getconf: no such configuration parameter `LFS_LIBS'

Fixes: d7f14c66c273 ("kbuild: Enable Large File Support for hostprogs")
Reported-by: Chen Feng <puck.chen@hisilicon.com>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

Comments

Uwe Kleine-König July 12, 2018, 11:08 a.m. | #1
On Thu, Jul 12, 2018 at 07:38:36PM +0900, Masahiro Yamada wrote:
> Suppress warnings for systems that do not recognize LFS_*.

> 

>  getconf: no such configuration parameter `LFS_CFLAGS'

>  getconf: no such configuration parameter `LFS_LDFLAGS'

>  getconf: no such configuration parameter `LFS_LIBS'

> 

> Fixes: d7f14c66c273 ("kbuild: Enable Large File Support for hostprogs")

> Reported-by: Chen Feng <puck.chen@hisilicon.com>

> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Which is the system that doesn't know about LFS_* and you care about?
Irrespective of that:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>


Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Masahiro Yamada July 12, 2018, 2:55 p.m. | #2
2018-07-12 20:08 GMT+09:00 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> On Thu, Jul 12, 2018 at 07:38:36PM +0900, Masahiro Yamada wrote:

>> Suppress warnings for systems that do not recognize LFS_*.

>>

>>  getconf: no such configuration parameter `LFS_CFLAGS'

>>  getconf: no such configuration parameter `LFS_LDFLAGS'

>>  getconf: no such configuration parameter `LFS_LIBS'

>>

>> Fixes: d7f14c66c273 ("kbuild: Enable Large File Support for hostprogs")

>> Reported-by: Chen Feng <puck.chen@hisilicon.com>

>> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

>

> Which is the system that doesn't know about LFS_* and you care about?


No particular system in my mind.


Chen Feng reported this before.

I also found this:
https://stackoverflow.com/questions/47367350/how-to-recompile-torvalds-linux-from-mac-osx-high-sierra



> Irrespective of that:

>

> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

>

> Best regards

> Uwe

>

> --

> Pengutronix e.K.                           | Uwe Kleine-König            |

> Industrial Linux Solutions                 | http://www.pengutronix.de/  |

> --

> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in

> the body of a message to majordomo@vger.kernel.org

> More majordomo info at  http://vger.kernel.org/majordomo-info.html




-- 
Best Regards
Masahiro Yamada

Patch

diff --git a/Makefile b/Makefile
index 0f035ae..abc74f8 100644
--- a/Makefile
+++ b/Makefile
@@ -353,9 +353,9 @@  CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
 	  else if [ -x /bin/bash ]; then echo /bin/bash; \
 	  else echo sh; fi ; fi)
 
-HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS)
-HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
-HOST_LFS_LIBS := $(shell getconf LFS_LIBS)
+HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS 2>/dev/null)
+HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS 2>/dev/null)
+HOST_LFS_LIBS := $(shell getconf LFS_LIBS 2>/dev/null)
 
 HOSTCC       = gcc
 HOSTCXX      = g++