[3/3] dfu: Provide more verbose error message

Message ID 20180712215253.4290-3-semen.protsenko@linaro.org
State Superseded
Headers show
Series
  • [1/3] dfu: Fix data abort in dfu_free_entities()
Related show

Commit Message

Sam Protsenko July 12, 2018, 9:52 p.m.
It might be useful for user to see some human-readable root cause
message in addition to "configuration failed" message, so that the issue
can be fixed quickly.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 drivers/dfu/dfu.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Lukasz Majewski July 13, 2018, 9:43 a.m. | #1
Hi Sam,

> It might be useful for user to see some human-readable root cause

> message in addition to "configuration failed" message, so that the

> issue can be fixed quickly.

> 

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

> ---

>  drivers/dfu/dfu.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c

> index 5b9abd685d..318949529b 100644

> --- a/drivers/dfu/dfu.c

> +++ b/drivers/dfu/dfu.c

> @@ -71,6 +71,7 @@ int dfu_init_env_entities(char *interface, char

> *devstr) ret = dfu_config_entities(env_bkp, interface, devstr);

>  	if (ret) {

>  		pr_err("DFU entities configuration failed!\n");

> +		pr_err("(partition table does not match

> dfu_alt_info?)\n"); goto done;

>  	}

>  


Acked-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

Patch

diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
index 5b9abd685d..318949529b 100644
--- a/drivers/dfu/dfu.c
+++ b/drivers/dfu/dfu.c
@@ -71,6 +71,7 @@  int dfu_init_env_entities(char *interface, char *devstr)
 	ret = dfu_config_entities(env_bkp, interface, devstr);
 	if (ret) {
 		pr_err("DFU entities configuration failed!\n");
+		pr_err("(partition table does not match dfu_alt_info?)\n");
 		goto done;
 	}