| Message ID | 1532052249-1894-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | ab948cd21d25ba2f54832fc98a59eea90e680eba |
| Headers | show |
| Series | fdt_support: make FDT_FIXUP_PARTITIONS depend on CMD_MTDPARTS | expand |
On 19 July 2018 at 20:04, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > fdt_fixup_mtdparts() calls mtdparts_init() and device_find(), > which are defined in cmd/mtdparts.c > > The combination of FDT_FIXUP_PARTITIONS=y and CMD_MTDPARTS=n > emits the following link error: > > common/fdt_support.c:903: undefined reference to `mtdparts_init' > common/fdt_support.c:914: undefined reference to `device_find' > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > lib/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 26 July 2018 at 14:17, Simon Glass <sjg@chromium.org> wrote: > On 19 July 2018 at 20:04, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: >> fdt_fixup_mtdparts() calls mtdparts_init() and device_find(), >> which are defined in cmd/mtdparts.c >> >> The combination of FDT_FIXUP_PARTITIONS=y and CMD_MTDPARTS=n >> emits the following link error: >> >> common/fdt_support.c:903: undefined reference to `mtdparts_init' >> common/fdt_support.c:914: undefined reference to `device_find' >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> --- >> >> lib/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/lib/Kconfig b/lib/Kconfig index a77bf1c..622f3c2 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -334,7 +334,7 @@ config SPL_OF_LIBFDT config FDT_FIXUP_PARTITIONS bool "overwrite MTD partitions in DTS through defined in 'mtdparts'" depends on OF_LIBFDT - default n + depends on CMD_MTDPARTS help Allow overwriting defined partitions in the device tree blob using partition info defined in the 'mtdparts' environment
fdt_fixup_mtdparts() calls mtdparts_init() and device_find(), which are defined in cmd/mtdparts.c The combination of FDT_FIXUP_PARTITIONS=y and CMD_MTDPARTS=n emits the following link error: common/fdt_support.c:903: undefined reference to `mtdparts_init' common/fdt_support.c:914: undefined reference to `device_find' Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- lib/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)