[2/3] gnutls: rationalise libunistring arguments

Message ID 20180723115124.27548-2-ross.burton@intel.com
State New
Headers show
Series
  • [1/3] libidn2: add new version
Related show

Commit Message

Ross Burton July 23, 2018, 11:51 a.m.
No need to pass --without-libunistring-prefix, and it looks a lot like we're
trying to disable it.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/recipes-support/gnutls/gnutls.inc | 1 -
 1 file changed, 1 deletion(-)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Khem Raj July 27, 2018, 10:24 a.m. | #1
On Mon, Jul 23, 2018 at 4:51 AM Ross Burton <ross.burton@intel.com> wrote:
>

> No need to pass --without-libunistring-prefix, and it looks a lot like we're

> trying to disable it.

>


This sneaked in and I did not notice it in the series, but its going
to cause regression
on build machines who installed libunistring on host. Its also because
gnuts is using
non standard AC macro called AC_LIB_HAVE_LINKFLAGS to detect this
library and it seems to be confusing cross builds.

This commit is essentially reverting
http://git.openembedded.org/openembedded-core/commit/?id=ee0b0da237c1661f43e27e26e0ab24b7d8ed174f

which was added to fix the above case. This should be reverted.

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta/recipes-support/gnutls/gnutls.inc | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc

> index 98ec8d9667b..b62a137e595 100644

> --- a/meta/recipes-support/gnutls/gnutls.inc

> +++ b/meta/recipes-support/gnutls/gnutls.inc

> @@ -41,7 +41,6 @@ EXTRA_OECONF = " \

>      --enable-local-libopts \

>      --enable-openssl-compatibility \

>      --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \

> -    --without-libunistring-prefix \

>  "

>

>  LDFLAGS_append_libc-musl = " -largp"

> --

> 2.11.0

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index 98ec8d9667b..b62a137e595 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -41,7 +41,6 @@  EXTRA_OECONF = " \
     --enable-local-libopts \
     --enable-openssl-compatibility \
     --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
-    --without-libunistring-prefix \
 "
 
 LDFLAGS_append_libc-musl = " -largp"