From patchwork Mon Jul 23 20:17:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 142641 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp6505391ljj; Mon, 23 Jul 2018 14:17:38 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcVoBvRIkvONC9xf422qT5f/gT95EE0P4jnSpnzB5YWyNe8FNo/vBm9aOwvyQAzrT/o0Hyi X-Received: by 2002:a37:9f90:: with SMTP id i138-v6mr12798877qke.113.1532380657976; Mon, 23 Jul 2018 14:17:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532380657; cv=none; d=google.com; s=arc-20160816; b=Ga8Ql9Pdp9xP8tJJyH6kABKt/R3PyXrLpdUIttKF07uso9Y0dogE9nnABATVnmeOFD AHGtCIpaOdscJBNUsKrQz8yZIURoJ9t6IZ2hxE4k+iHOsoyyNPlXlqvI2zlHtkl7YCNJ neAmSsKNmT7Ck8Hx/p3UJleArMMAfXMoc1lwU09w18eIao0ytIk0enw8bo8UMNYLPzu/ qHw34+th3aOawUpML9cA3TxYoCjt9L4UImM1lE1UMPfSbmTUb0Uk6srP7K7ZLNjRrNvj 0dCE34Ha4sV9tD/nXe17RsiLzIWt5UWymiOEfI9Y7MijJdQ8x4hL8pO9/EaTFjlupC5H LEnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=oW1WcFafgHAkdjm0CsLyqQUr/F68AJFRJMt7rynJMsM=; b=fwhdYl1ZxivvmaKPceUai5Hsj5ZPlRZn6tsCGmUjSg8rmO3Y981h+QJXtsGG49uDZq ncX+xe0nC/i5T/WBj2kUol0QT1igWb7+Giv+IQbLEsVSBLH6I+jGgB//NiFUzCUoa76b zoaS00zbKSAHXTUHwVOULyVGw/K0+H0u8Gi+oqtefJNLEHyYH9hI0aDQOJU5GVCzYG+/ ygII5eCO6KM+iiRyqGrg6KYGI9WBJiE/waoK9AFGC2UV9b6jLja8WUuSPLWR3exRwoDI DSEgkmeBl+Sk2iyfKwMydPVLwZIU0QK+XlsD8t8eYYqDp5y6558uWrsatWkv5MEVYf0Y i2IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Pll/qB+l"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l125-v6si4452009qkd.207.2018.07.23.14.17.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 23 Jul 2018 14:17:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Pll/qB+l"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1]:36706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiD3-0004Ui-Cp for patch@linaro.org; Mon, 23 Jul 2018 17:17:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhKK-0003Y6-KP for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhKJ-0005Ce-Dz for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:04 -0400 Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:43132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhKJ-0005CV-7H; Mon, 23 Jul 2018 16:21:03 -0400 Received: by mail-oi0-x233.google.com with SMTP id b15-v6so3468635oib.10; Mon, 23 Jul 2018 13:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oW1WcFafgHAkdjm0CsLyqQUr/F68AJFRJMt7rynJMsM=; b=Pll/qB+ldnERQMAD1opOf1OR9FRQNDquu6vkgDXCiEj9HVQJXXbdnFISdm/cb0URnc 0JKGh2MkBFc0SmK5RpI8Z64WgPXJ0UkJmZPLVc3yknWSxemtsUP4RUOkk11csbqnj1np 5N41bmdA3/wpP5Gy/FuI8kUR7YYRRadAvFd52FBR8WlTcH8+lgn0cg4yphINWyl6ybn/ fsZuFPLMHf2xoxGbAzfZcfxOdfTFH7lMpAoXMY/PADbbvHjjHlez+Uc7BHuyh4Ro4P6D JqGi84cly2WST+H6mVE4oVXtYp85aoPyXlP8merEJ4TgD7oxi+iXNJhog3vKzolShjAI oCwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=oW1WcFafgHAkdjm0CsLyqQUr/F68AJFRJMt7rynJMsM=; b=hUE/nM87zEtqjdQrKxlKCkHbxSf/ed17cEMfviPPi/3eqNcesq9ZRmCwlrkgMmi30T wXQ/p1M/IsfWzu1wxLZWo5R7t522jQpw5m3/4itbILI3CWLW1315UMlTCF1LoU6P5g+U eaKih6ppyzhKRmjEaTIt/cyOjiOb0YN4KOwkSUOZpY79aAAXz1GqUtVaWcQT055Ukc7M oXwOGSk0FsJPDm6j/yJ2lOccnC9QZDBzIQADzJ7Q0y9IXqoXlAlAK9MtI4kJOFvo54MY x7qrlIlQEPo9k6fINtxfU3QQN1xatkI1juoRHqteZyu0B5VbKFq5GVoDE07pfFD5lyUR bipg== X-Gm-Message-State: AOUpUlF3AsVvWR0PNfCAF08Ux//2mOyfEiud41UbjVwOIR+AeYnXG1sR 2hlwJJZnbKXgvuTiWJ+HIiTzcKtGHgn5Ig== X-Received: by 2002:aca:c40e:: with SMTP id u14-v6mr289141oif.288.1532377262113; Mon, 23 Jul 2018 13:21:02 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id u18-v6sm6621311oiv.10.2018.07.23.13.21.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:01 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:18 -0500 Message-Id: <20180723201748.25573-70-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::233 Subject: [Qemu-devel] [PATCH 69/99] target/arm: Fix fp_status_f16 tininess before rounding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell In commit d81ce0ef2c4f105 we added an extra float_status field fp_status_fp16 for Arm, but forgot to initialize it correctly by setting it to float_tininess_before_rounding. This currently will only cause problems for the new V8_FP16 feature, since the float-to-float conversion code doesn't use it yet. The effect would be that we failed to set the Underflow IEEE exception flag in all the cases where we should. Add the missing initialization. Fixes: d81ce0ef2c4f105 Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Peter Maydell Message-id: 20180512004311.9299-16-richard.henderson@linaro.org (cherry picked from commit bcc531f0364796104df4443d17f99b5fb494eca2) Signed-off-by: Michael Roth --- target/arm/cpu.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 022d8c5787..7ebe3fcadf 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -311,6 +311,8 @@ static void arm_cpu_reset(CPUState *s) &env->vfp.fp_status); set_float_detect_tininess(float_tininess_before_rounding, &env->vfp.standard_fp_status); + set_float_detect_tininess(float_tininess_before_rounding, + &env->vfp.fp_status_f16); #ifndef CONFIG_USER_ONLY if (kvm_enabled()) { kvm_arm_reset_vcpu(cpu);