rtc: sh: remove unused variable rtc_dev

Message ID 20180727151015.3930-1-anders.roxell@linaro.org
State Accepted
Commit 8856541557f3626beec43aa0821b2e0f031f0153
Headers show
Series
  • rtc: sh: remove unused variable rtc_dev
Related show

Commit Message

Anders Roxell July 27, 2018, 3:10 p.m.
When building rtc-sh, rtc_dev isn't used in function __sh_rtc_periodic.
drivers/rtc/rtc-sh.c: In function ‘__sh_rtc_periodic’:
drivers/rtc/rtc-sh.c:146:21: warning: unused variable ‘rtc_dev’ [-Wunused-variable]
  struct rtc_device *rtc_dev = rtc->rtc_dev;
                     ^~~~~~~
Remove the declaration of rtc_dev to dispose the warning.

Fixes: ec623ff014c4 ("rtc: sh: remove dead code")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/rtc/rtc-sh.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.18.0

Comments

Alexandre Belloni July 27, 2018, 3:28 p.m. | #1
On 27/07/2018 17:10:15+0200, Anders Roxell wrote:
> When building rtc-sh, rtc_dev isn't used in function __sh_rtc_periodic.

> drivers/rtc/rtc-sh.c: In function ‘__sh_rtc_periodic’:

> drivers/rtc/rtc-sh.c:146:21: warning: unused variable ‘rtc_dev’ [-Wunused-variable]

>   struct rtc_device *rtc_dev = rtc->rtc_dev;

>                      ^~~~~~~

> Remove the declaration of rtc_dev to dispose the warning.

> 

> Fixes: ec623ff014c4 ("rtc: sh: remove dead code")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---

>  drivers/rtc/rtc-sh.c | 1 -

>  1 file changed, 1 deletion(-)

> 

Applied, thanks.

It is weird that kbuild didn't complain about it though.

-- 
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Patch

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index 25ec6a937858..51ba414798a8 100644
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -143,7 +143,6 @@  static int __sh_rtc_alarm(struct sh_rtc *rtc)
 
 static int __sh_rtc_periodic(struct sh_rtc *rtc)
 {
-	struct rtc_device *rtc_dev = rtc->rtc_dev;
 	unsigned int tmp, pending;
 
 	tmp = readb(rtc->regbase + RCR2);