Applied "ASoC: doc: Replace open code with params_set_format()" to the asoc tree

Message ID
State New
Headers show
  • Applied "ASoC: doc: Replace open code with params_set_format()" to the asoc tree
Related show

Commit Message

Mark Brown July 26, 2018, 4:11 p.m.
The patch

   ASoC: doc: Replace open code with params_set_format()

has been applied to the asoc tree at 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From 533a9274850b041b32fbe6d1df58a5c5b0b9e652 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <>

Date: Wed, 25 Jul 2018 23:17:18 +0200
Subject: [PATCH] ASoC: doc: Replace open code with params_set_format()

The example code in dpcm.rst contains an open code calling
snd_mask_set(), and this can be better represented with
params_set_format() instead.  This automatically fixes the sparse
warning about snd_pcm_format_t handling, too.

Signed-off-by: Takashi Iwai <>

Signed-off-by: Mark Brown <>

 Documentation/sound/soc/dpcm.rst | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


Alsa-devel mailing list


diff --git a/Documentation/sound/soc/dpcm.rst b/Documentation/sound/soc/dpcm.rst
index 395e5a516282..fe61e02277f8 100644
--- a/Documentation/sound/soc/dpcm.rst
+++ b/Documentation/sound/soc/dpcm.rst
@@ -254,9 +254,7 @@  configuration.
 	channels->min = channels->max = 2;
 	/* set DAI0 to 16 bit */
-	snd_mask_set(&params->masks[SNDRV_PCM_HW_PARAM_FORMAT -
-				    SNDRV_PCM_FORMAT_S16_LE);
+	params_set_format(params, SNDRV_PCM_FORMAT_S16_LE);
 	return 0;