| Message ID | 20180801123111.3595-5-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/arm sve fixes | expand |
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson <richard.henderson@linaro.org> wrote: > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com> Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com> Laurent > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 87594a8adb..c3cbec9cf5 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1042,7 +1042,7 @@ void HELPER(sve_movz_d)(void *vd, void *vn, void *vg, uint32_t desc) > uint64_t *d = vd, *n = vn; > uint8_t *pg = vg; > for (i = 0; i < opr_sz; i += 1) { > - d[i] = n[1] & -(uint64_t)(pg[H1(i)] & 1); > + d[i] = n[i] & -(uint64_t)(pg[H1(i)] & 1); > } > } > > -- > 2.17.1 >
Richard Henderson <richard.henderson@linaro.org> writes: > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 87594a8adb..c3cbec9cf5 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1042,7 +1042,7 @@ void HELPER(sve_movz_d)(void *vd, void *vn, void *vg, uint32_t desc) > uint64_t *d = vd, *n = vn; > uint8_t *pg = vg; > for (i = 0; i < opr_sz; i += 1) { > - d[i] = n[1] & -(uint64_t)(pg[H1(i)] & 1); > + d[i] = n[i] & -(uint64_t)(pg[H1(i)] & 1); > } > } -- Alex Bennée
On 08/01/2018 09:31 AM, Richard Henderson wrote: > Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 87594a8adb..c3cbec9cf5 100644 > --- a/target/arm/sve_helper.c > +++ b/target/arm/sve_helper.c > @@ -1042,7 +1042,7 @@ void HELPER(sve_movz_d)(void *vd, void *vn, void *vg, uint32_t desc) > uint64_t *d = vd, *n = vn; > uint8_t *pg = vg; > for (i = 0; i < opr_sz; i += 1) { > - d[i] = n[1] & -(uint64_t)(pg[H1(i)] & 1); > + d[i] = n[i] & -(uint64_t)(pg[H1(i)] & 1); :))) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > } > } > >
diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index 87594a8adb..c3cbec9cf5 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve_helper.c @@ -1042,7 +1042,7 @@ void HELPER(sve_movz_d)(void *vd, void *vn, void *vg, uint32_t desc) uint64_t *d = vd, *n = vn; uint8_t *pg = vg; for (i = 0; i < opr_sz; i += 1) { - d[i] = n[1] & -(uint64_t)(pg[H1(i)] & 1); + d[i] = n[i] & -(uint64_t)(pg[H1(i)] & 1); } }
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com> Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/sve_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1