[edk2,v1,edk-platforms,1/2] Platform/HiKey960: add PL011UartClockLib

Message ID 1533782749-29455-1-git-send-email-haojian.zhuang@linaro.org
State New
Headers show
Series
  • Fix missing PL011UartClockLib
Related show

Commit Message

Haojian Zhuang Aug. 9, 2018, 2:45 a.m.
Since PL011UartClockLib is required by PL011 SerialPortLib.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>

---
 Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Udit Kumar Sept. 1, 2018, 1:03 p.m. | #1
> -----Original Message-----

> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Haojian

> Zhuang

> Sent: Thursday, August 9, 2018 8:16 AM

> To: edk2-devel@lists.01.org

> Subject: [edk2] [PATCH v1 edk-platforms 1/2] Platform/HiKey960: add

> PL011UartClockLib

> 

> Since PL011UartClockLib is required by PL011 SerialPortLib.

> 

> Cc: Leif Lindholm <leif.lindholm@linaro.org>

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>

> ---

>  Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc

> b/Platform/Hisilicon/HiKey960/HiKey960.dsc

> index be13714b9c19..15990b788336 100644

> --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc

> +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc

> @@ -45,6 +45,7 @@ [LibraryClasses.common]

>    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf

>    BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf

> 

> +

> PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartCl

> ockLib.inf


I think, this lib is part of common dsc of HiSilicon platforms . 
 
> SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib

> .inf

> 

> RealTimeClockLib|ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031Re

> alTimeClockLib.inf

>    TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf

> --

> 2.7.4

> 

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist

> s.01.org%2Fmailman%2Flistinfo%2Fedk2-

> devel&amp;data=02%7C01%7Cudit.kumar%40nxp.com%7C6ace3239bab84b

> e9ded708d5fda23ca8%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%

> 7C636693795605123423&amp;sdata=ixi5vsyZ1Z471FoRFlCRvRx9IrcNGgXY3gt

> 3QglboA8%3D&amp;reserved=0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
index be13714b9c19..15990b788336 100644
--- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
+++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
@@ -45,6 +45,7 @@  [LibraryClasses.common]
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
   BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
 
+  PL011UartClockLib|ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
   SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
   RealTimeClockLib|ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
   TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf