| Message ID | 20180813223733.991653-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 64999fa7aa2c076ec6d05aee481f11f5296ceb8c |
| Headers | show |
| Series | fsi: ast: select GENERIC_ALLOCATOR | expand |
On Tue, 2018-08-14 at 00:37 +0200, Arnd Bergmann wrote: > In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver > fails to link: > > ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined! > ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined! > ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undefined! > ERROR: "gen_pool_free" [drivers/fsi/fsi-master-ast-cf.ko] undefined! > > Select the dependency as all other users do. > > Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Thanks, I'll pick it up and send to Greg with a slightly different subject Cheers, Ben. > drivers/fsi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig > index af3a20dd5aa4..99c99a5d57fe 100644 > --- a/drivers/fsi/Kconfig > +++ b/drivers/fsi/Kconfig > @@ -46,6 +46,7 @@ config FSI_MASTER_AST_CF > tristate "FSI master based on Aspeed ColdFire coprocessor" > depends on GPIOLIB > depends on GPIO_ASPEED > + select GENERIC_ALLOCATOR > ---help--- > This option enables a FSI master using the AST2400 and AST2500 GPIO > lines driven by the internal ColdFire coprocessor. This requires
diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig index af3a20dd5aa4..99c99a5d57fe 100644 --- a/drivers/fsi/Kconfig +++ b/drivers/fsi/Kconfig @@ -46,6 +46,7 @@ config FSI_MASTER_AST_CF tristate "FSI master based on Aspeed ColdFire coprocessor" depends on GPIOLIB depends on GPIO_ASPEED + select GENERIC_ALLOCATOR ---help--- This option enables a FSI master using the AST2400 and AST2500 GPIO lines driven by the internal ColdFire coprocessor. This requires
In randconfig builds without CONFIG_GENERIC_ALLOCATOR, this driver fails to link: ERROR: "gen_pool_alloc_algo" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "gen_pool_fixed_alloc" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "of_gen_pool_get" [drivers/fsi/fsi-master-ast-cf.ko] undefined! ERROR: "gen_pool_free" [drivers/fsi/fsi-master-ast-cf.ko] undefined! Select the dependency as all other users do. Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/fsi/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.18.0