[edk2,v2,edk-platforms,1/3] Silicon/Hi3660: fix LDO9_VSET register definition

Message ID 1534384166-15673-2-git-send-email-haojian.zhuang@linaro.org
State New
Headers show
Series
  • enable eMMC/SD controller on HiKey
Related show

Commit Message

Haojian Zhuang Aug. 16, 2018, 1:49 a.m.
Fix the LDO9_VSET register definition in PMIC. LDO9 is used
by Designware SD controller. Without this fix, SD controller
fails to operate SD card since lack of right voltage setting.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>

---
 Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Aug. 16, 2018, 9:23 a.m. | #1
On Thu, Aug 16, 2018 at 09:49:24AM +0800, Haojian Zhuang wrote:
> Fix the LDO9_VSET register definition in PMIC. LDO9 is used

> by Designware SD controller. Without this fix, SD controller

> fails to operate SD card since lack of right voltage setting.

> 

> Cc: Leif Lindholm <leif.lindholm@linaro.org>

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as d11581e5fd.

> ---

>  Silicon/Hisilicon/Hi3660/Include/Hi3660.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h

> index 5fbf32267657..6e0587f7783a 100644

> --- a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h

> +++ b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h

> @@ -58,7 +58,7 @@

>  #define USB3OTG_PHY_CR_CAP_ADDR                 (1 << 0)

>  

>  #define PMU_REG_BASE                            0xFFF34000

> -#define PMIC_LDO9_VSET_REG                      (PMU_REG_BASE + (0x068 << 2))

> +#define PMIC_LDO9_VSET_REG                      (PMU_REG_BASE + (0x06b << 2))

>  #define LDO9_VSET_MASK                          (7 << 0)

>  

>  #define PMIC_LDO16_ONOFF_ECO_REG                (PMU_REG_BASE + (0x078 << 2))

> -- 

> 2.7.4

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
index 5fbf32267657..6e0587f7783a 100644
--- a/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
+++ b/Silicon/Hisilicon/Hi3660/Include/Hi3660.h
@@ -58,7 +58,7 @@ 
 #define USB3OTG_PHY_CR_CAP_ADDR                 (1 << 0)
 
 #define PMU_REG_BASE                            0xFFF34000
-#define PMIC_LDO9_VSET_REG                      (PMU_REG_BASE + (0x068 << 2))
+#define PMIC_LDO9_VSET_REG                      (PMU_REG_BASE + (0x06b << 2))
 #define LDO9_VSET_MASK                          (7 << 0)
 
 #define PMIC_LDO16_ONOFF_ECO_REG                (PMU_REG_BASE + (0x078 << 2))