[edk2,edk2-platforms,v3,17/36] Hisilicon/I2C: Fix a typo issue

Message ID 20180816121239.44129-18-ming.huang@linaro.org
State New
Headers show
Series
  • Upload for D06 platform
Related show

Commit Message

Ming Huang Aug. 16, 2018, 12:12 p.m.
Modify spedd to Speed.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang <ming.huang@linaro.org>

---
 Silicon/Hisilicon/Library/I2CLib/I2CHw.h  | 2 +-
 Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Aug. 21, 2018, 9:45 p.m. | #1
Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C
library. It can (and should) go in before D06 support.

For the three patches:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


Pushed as 4e6af5fa1b..342330470f.

On Thu, Aug 16, 2018 at 08:12:20PM +0800, Ming Huang wrote:
> Modify spedd to Speed.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ming Huang <ming.huang@linaro.org>

> ---

>  Silicon/Hisilicon/Library/I2CLib/I2CHw.h  | 2 +-

>  Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +-

>  2 files changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h

> index d77aea509e..6fd7b8183e 100644

> --- a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h

> +++ b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h

> @@ -81,7 +81,7 @@

>       struct

>       {

>          UINT32      master                : 1   ;

> -        UINT32      spedd                 : 2   ;

> +        UINT32      Speed                 : 2   ;

>          UINT32      slave_10bit           : 1   ;

>          UINT32      master_10bit          : 1   ;

>          UINT32      restart_en            : 1   ;

> diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c

> index 59633106ce..ed44ac204f 100644

> --- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c

> +++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c

> @@ -158,7 +158,7 @@ I2CInit (

>  

>    I2C_REG_READ (Base + I2C_CON_OFFSET, I2cControlReg.Val32);

>    I2cControlReg.bits.master = 1;

> -  I2cControlReg.bits.spedd = 0x1;

> +  I2cControlReg.bits.Speed = 0x1;

>    I2cControlReg.bits.restart_en = 1;

>    I2cControlReg.bits.slave_disable = 1;

>    I2C_REG_WRITE (Base + I2C_CON_OFFSET, I2cControlReg.Val32);

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Aug. 21, 2018, 9:48 p.m. | #2
Err, that was 13, 14 and 17 in v3.

In v2, it's 20, 21, 24.

(I pushed the right patches, I just replied to the wrong email.)

On Tue, Aug 21, 2018 at 10:45:44PM +0100, Leif Lindholm wrote:
> Patches 13, 14 and 17/43 are just cleanup and refactoring of I2C

> library. It can (and should) go in before D06 support.

> 

> For the three patches:

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> 

> Pushed as 4e6af5fa1b..342330470f.

> 

> On Thu, Aug 16, 2018 at 08:12:20PM +0800, Ming Huang wrote:

> > Modify spedd to Speed.

> > 

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Ming Huang <ming.huang@linaro.org>

> > ---

> >  Silicon/Hisilicon/Library/I2CLib/I2CHw.h  | 2 +-

> >  Silicon/Hisilicon/Library/I2CLib/I2CLib.c | 2 +-

> >  2 files changed, 2 insertions(+), 2 deletions(-)

> > 

> > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h

> > index d77aea509e..6fd7b8183e 100644

> > --- a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h

> > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h

> > @@ -81,7 +81,7 @@

> >       struct

> >       {

> >          UINT32      master                : 1   ;

> > -        UINT32      spedd                 : 2   ;

> > +        UINT32      Speed                 : 2   ;

> >          UINT32      slave_10bit           : 1   ;

> >          UINT32      master_10bit          : 1   ;

> >          UINT32      restart_en            : 1   ;

> > diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c

> > index 59633106ce..ed44ac204f 100644

> > --- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c

> > +++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c

> > @@ -158,7 +158,7 @@ I2CInit (

> >  

> >    I2C_REG_READ (Base + I2C_CON_OFFSET, I2cControlReg.Val32);

> >    I2cControlReg.bits.master = 1;

> > -  I2cControlReg.bits.spedd = 0x1;

> > +  I2cControlReg.bits.Speed = 0x1;

> >    I2cControlReg.bits.restart_en = 1;

> >    I2cControlReg.bits.slave_disable = 1;

> >    I2C_REG_WRITE (Base + I2C_CON_OFFSET, I2cControlReg.Val32);

> > -- 

> > 2.17.0

> > 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
index d77aea509e..6fd7b8183e 100644
--- a/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
+++ b/Silicon/Hisilicon/Library/I2CLib/I2CHw.h
@@ -81,7 +81,7 @@ 
      struct
      {
         UINT32      master                : 1   ;
-        UINT32      spedd                 : 2   ;
+        UINT32      Speed                 : 2   ;
         UINT32      slave_10bit           : 1   ;
         UINT32      master_10bit          : 1   ;
         UINT32      restart_en            : 1   ;
diff --git a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
index 59633106ce..ed44ac204f 100644
--- a/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
+++ b/Silicon/Hisilicon/Library/I2CLib/I2CLib.c
@@ -158,7 +158,7 @@  I2CInit (
 
   I2C_REG_READ (Base + I2C_CON_OFFSET, I2cControlReg.Val32);
   I2cControlReg.bits.master = 1;
-  I2cControlReg.bits.spedd = 0x1;
+  I2cControlReg.bits.Speed = 0x1;
   I2cControlReg.bits.restart_en = 1;
   I2cControlReg.bits.slave_disable = 1;
   I2C_REG_WRITE (Base + I2C_CON_OFFSET, I2cControlReg.Val32);