| Message ID | 1535337230-13222-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 21bfc8309cca566b76fc0c1d65c598e62f8971a1 |
| Headers | show |
| Series | reiserfs: remove workaround code for GCC 3.x | expand |
On 8/26/18 10:33 PM, Masahiro Yamada wrote: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > bumped the minimum GCC version to 4.6 for all architectures. > > The workaround code in fs/reiserfs/Makefile is obsolete now. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Acked-by: Jeff Mahoney <jeffm@suse.com> Thanks, -Jeff > --- > > fs/reiserfs/Makefile | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile > index a39a562..bd29c58 100644 > --- a/fs/reiserfs/Makefile > +++ b/fs/reiserfs/Makefile > @@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y) > reiserfs-objs += xattr_acl.o > endif > > -# gcc -O2 (the kernel default) is overaggressive on ppc32 when many inline > -# functions are used. This causes the compiler to advance the stack > -# pointer out of the available stack space, corrupting kernel space, > -# and causing a panic. Since this behavior only affects ppc32, this ifeq > -# will work around it. If any other architecture displays this behavior, > -# add it here. > -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1) > - > TAGS: > etags *.c > - > -- Jeff Mahoney SUSE Labs
Masahiro Yamada <yamada.masahiro@socionext.com> writes: > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > bumped the minimum GCC version to 4.6 for all architectures. > > The workaround code in fs/reiserfs/Makefile is obsolete now. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > fs/reiserfs/Makefile | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile > index a39a562..bd29c58 100644 > --- a/fs/reiserfs/Makefile > +++ b/fs/reiserfs/Makefile > @@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y) > reiserfs-objs += xattr_acl.o > endif > > -# gcc -O2 (the kernel default) is overaggressive on ppc32 when many inline > -# functions are used. This causes the compiler to advance the stack > -# pointer out of the available stack space, corrupting kernel space, > -# and causing a panic. Since this behavior only affects ppc32, this ifeq > -# will work around it. If any other architecture displays this behavior, > -# add it here. > -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1) > - > TAGS: > etags *.c Oh wow that's gross. Thanks for cleaning it up. Acked-by: Michael Ellerman <mpe@ellerman.id.au> cheers
diff --git a/fs/reiserfs/Makefile b/fs/reiserfs/Makefile index a39a562..bd29c58 100644 --- a/fs/reiserfs/Makefile +++ b/fs/reiserfs/Makefile @@ -26,14 +26,5 @@ ifeq ($(CONFIG_REISERFS_FS_POSIX_ACL),y) reiserfs-objs += xattr_acl.o endif -# gcc -O2 (the kernel default) is overaggressive on ppc32 when many inline -# functions are used. This causes the compiler to advance the stack -# pointer out of the available stack space, corrupting kernel space, -# and causing a panic. Since this behavior only affects ppc32, this ifeq -# will work around it. If any other architecture displays this behavior, -# add it here. -ccflags-$(CONFIG_PPC32) := $(call cc-ifversion, -lt, 0400, -O1) - TAGS: etags *.c -
Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") bumped the minimum GCC version to 4.6 for all architectures. The workaround code in fs/reiserfs/Makefile is obsolete now. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- fs/reiserfs/Makefile | 9 --------- 1 file changed, 9 deletions(-) -- 2.7.4