diff mbox series

kernel/SRCU: Fix ctags

Message ID 20180828154403.9207-1-semen.protsenko@linaro.org
State Superseded
Headers show
Series kernel/SRCU: Fix ctags | expand

Commit Message

Sam Protsenko Aug. 28, 2018, 3:44 p.m. UTC
ctags indexing ("make tags" command) throws this warning:

    ctags: Warning: include/linux/notifier.h:125:
    null expansion of name pattern "\1"

This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
getting rid of line break.

Similar fix was already done in commit 25528213fe9f ("tags: Fix
DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

---
 include/linux/notifier.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.18.0

Comments

Sam Protsenko Sept. 11, 2018, 4:57 p.m. UTC | #1
Hi guys,

It's been a while since I sent this one. Can we please merge it if
there is no objections?

Thanks.

On Tue, Aug 28, 2018 at 6:44 PM, Sam Protsenko
<semen.protsenko@linaro.org> wrote:
> ctags indexing ("make tags" command) throws this warning:

>

>     ctags: Warning: include/linux/notifier.h:125:

>     null expansion of name pattern "\1"

>

> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by

> getting rid of line break.

>

> Similar fix was already done in commit 25528213fe9f ("tags: Fix

> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.

>

> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

> ---

>  include/linux/notifier.h | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

>

> diff --git a/include/linux/notifier.h b/include/linux/notifier.h

> index f35c7bf76143..2c6ff4cde938 100644

> --- a/include/linux/notifier.h

> +++ b/include/linux/notifier.h

> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);

>

>  #ifdef CONFIG_TREE_SRCU

>  #define _SRCU_NOTIFIER_HEAD(name, mod)                         \

> -       static DEFINE_PER_CPU(struct srcu_data,                 \

> -                       name##_head_srcu_data);                 \

> +       static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \

>         mod struct srcu_notifier_head name =                    \

>                         SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)

>

> --

> 2.18.0

>
diff mbox series

Patch

diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index f35c7bf76143..2c6ff4cde938 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -122,8 +122,7 @@  extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
 
 #ifdef CONFIG_TREE_SRCU
 #define _SRCU_NOTIFIER_HEAD(name, mod)				\
-	static DEFINE_PER_CPU(struct srcu_data,			\
-			name##_head_srcu_data);			\
+	static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data);	\
 	mod struct srcu_notifier_head name =			\
 			SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)