[2/4] sched/numa: remove unused nr_running field

Message ID 1535548752-4434-3-git-send-email-vincent.guittot@linaro.org
State Accepted
Commit 7477a3504e619768c9e972dafe2907e6b8ed9823
Headers show
Series
  • sched/numa: remove unused code
Related show

Commit Message

Vincent Guittot Aug. 29, 2018, 1:19 p.m.
nr_running in struct numa_stats is not used anywhere in the code.

Remove it.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

---
 kernel/sched/fair.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.7.4

Comments

Srikar Dronamraju Sept. 4, 2018, 6:40 a.m. | #1
* Vincent Guittot <vincent.guittot@linaro.org> [2018-08-29 15:19:10]:

> nr_running in struct numa_stats is not used anywhere in the code.

> 

> Remove it.

> 

> Cc: Peter Zijlstra <peterz@infradead.org>

> Cc: Ingo Molnar <mingo@redhat.com>

> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> Cc: Rik van Riel <riel@surriel.com>

> Cc: linux-kernel@vger.kernel.org (open list)

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---

>  kernel/sched/fair.c | 3 ---

>  1 file changed, 3 deletions(-)


Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>


-- 
Thanks and Regards
Srikar Dronamraju

Patch

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c2b8bf4..cff1682 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -1454,8 +1454,6 @@  struct numa_stats {
 
 	/* Total compute capacity of CPUs on a node */
 	unsigned long compute_capacity;
-
-	unsigned int nr_running;
 };
 
 /*
@@ -1469,7 +1467,6 @@  static void update_numa_stats(struct numa_stats *ns, int nid)
 	for_each_cpu(cpu, cpumask_of_node(nid)) {
 		struct rq *rq = cpu_rq(cpu);
 
-		ns->nr_running += rq->nr_running;
 		ns->load += weighted_cpuload(rq);
 		ns->compute_capacity += capacity_of(cpu);
 	}