[2/2] gpio: tps65xxx: Use SPDX license tag

Message ID 20180829145827.9852-1-linus.walleij@linaro.org
State New
Headers show
Series
  • [1/2] gpio: tpx65xxx: Include the right header
Related show

Commit Message

Linus Walleij Aug. 29, 2018, 2:58 p.m.
I'm tired of boilerplate, use the SPDX tag.

Cc: Andrew F. Davis <afd@ti.com>
Cc: Keerthy <j-keerthy@ti.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/gpio/gpio-tps65086.c | 10 +---------
 drivers/gpio/gpio-tps6586x.c | 13 +------------
 drivers/gpio/gpio-tps65910.c |  7 +------
 drivers/gpio/gpio-tps65912.c | 10 +---------
 4 files changed, 4 insertions(+), 36 deletions(-)

-- 
2.17.1

Comments

Andrew F. Davis Aug. 29, 2018, 3:08 p.m. | #1
On 08/29/2018 09:58 AM, Linus Walleij wrote:
> I'm tired of boilerplate, use the SPDX tag.

> 

> Cc: Andrew F. Davis <afd@ti.com>

> Cc: Keerthy <j-keerthy@ti.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---



I'm assuming this will be done for all GPIO drivers at some point? Why
not one big conversion patch, or at least all by TI in one go. Anyway,

Acked-by: Andrew F. Davis <afd@ti.com>



>  drivers/gpio/gpio-tps65086.c | 10 +---------

>  drivers/gpio/gpio-tps6586x.c | 13 +------------

>  drivers/gpio/gpio-tps65910.c |  7 +------

>  drivers/gpio/gpio-tps65912.c | 10 +---------

>  4 files changed, 4 insertions(+), 36 deletions(-)

> 

> diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c

> index 47a8b209183c..2eea98ff4ea3 100644

> --- a/drivers/gpio/gpio-tps65086.c

> +++ b/drivers/gpio/gpio-tps65086.c

> @@ -1,16 +1,8 @@

> +// SPDX-License-Identifier: GPL-2.0

>  /*

>   * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/

>   *	Andrew F. Davis <afd@ti.com>

>   *

> - * This program is free software; you can redistribute it and/or

> - * modify it under the terms of the GNU General Public License version 2 as

> - * published by the Free Software Foundation.

> - *

> - * This program is distributed "as is" WITHOUT ANY WARRANTY of any

> - * kind, whether expressed or implied; without even the implied warranty

> - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

> - * GNU General Public License version 2 for more details.

> - *

>   * Based on the TPS65912 driver

>   */

>  

> diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c

> index f7404a6de55a..9b6cc74f47c8 100644

> --- a/drivers/gpio/gpio-tps6586x.c

> +++ b/drivers/gpio/gpio-tps6586x.c

> @@ -1,3 +1,4 @@

> +// SPDX-License-Identifier: GPL-2.0

>  /*

>   * TI TPS6586x GPIO driver

>   *

> @@ -7,18 +8,6 @@

>   * Based on tps6586x.c

>   * Copyright (c) 2010 CompuLab Ltd.

>   * Mike Rapoport <mike@compulab.co.il>

> - *

> - * This program is free software; you can redistribute it and/or modify it

> - * under the terms and conditions of the GNU General Public License,

> - * version 2, as published by the Free Software Foundation.

> - *

> - * This program is distributed in the hope it will be useful, but WITHOUT

> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or

> - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for

> - * more details.

> - *

> - * You should have received a copy of the GNU General Public License

> - * along with this program.  If not, see <http://www.gnu.org/licenses/>.

>   */

>  

>  #include <linux/errno.h>

> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c

> index 55c745b53d0f..0c785b0fd161 100644

> --- a/drivers/gpio/gpio-tps65910.c

> +++ b/drivers/gpio/gpio-tps65910.c

> @@ -1,3 +1,4 @@

> +// SPDX-License-Identifier: GPL-2.0+

>  /*

>   * TI TPS6591x GPIO driver

>   *

> @@ -5,12 +6,6 @@

>   *

>   * Author: Graeme Gregory <gg@slimlogic.co.uk>

>   * Author: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>

> - *

> - *  This program is free software; you can redistribute it and/or modify it

> - *  under  the terms of the GNU General  Public License as published by the

> - *  Free Software Foundation;  either version 2 of the License, or (at your

> - *  option) any later version.

> - *

>   */

>  

>  #include <linux/kernel.h>

> diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c

> index aac78d18437d..140b8786b545 100644

> --- a/drivers/gpio/gpio-tps65912.c

> +++ b/drivers/gpio/gpio-tps65912.c

> @@ -1,18 +1,10 @@

> +// SPDX-License-Identifier: GPL-2.0

>  /*

>   * GPIO driver for TI TPS65912x PMICs

>   *

>   * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/

>   *	Andrew F. Davis <afd@ti.com>

>   *

> - * This program is free software; you can redistribute it and/or

> - * modify it under the terms of the GNU General Public License version 2 as

> - * published by the Free Software Foundation.

> - *

> - * This program is distributed "as is" WITHOUT ANY WARRANTY of any

> - * kind, whether expressed or implied; without even the implied warranty

> - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

> - * GNU General Public License version 2 for more details.

> - *

>   * Based on the Arizona GPIO driver and the previous TPS65912 driver by

>   * Margarita Olaya Cabrera <magi@slimlogic.co.uk>

>   */

>
Keerthy Aug. 30, 2018, 3:04 a.m. | #2
On 8/29/2018 8:28 PM, Linus Walleij wrote:
> I'm tired of boilerplate, use the SPDX tag.


Reviewed-by: Keerthy <j-keerthy@ti.com>


> 

> Cc: Andrew F. Davis <afd@ti.com>

> Cc: Keerthy <j-keerthy@ti.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>   drivers/gpio/gpio-tps65086.c | 10 +---------

>   drivers/gpio/gpio-tps6586x.c | 13 +------------

>   drivers/gpio/gpio-tps65910.c |  7 +------

>   drivers/gpio/gpio-tps65912.c | 10 +---------

>   4 files changed, 4 insertions(+), 36 deletions(-)

> 

> diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c

> index 47a8b209183c..2eea98ff4ea3 100644

> --- a/drivers/gpio/gpio-tps65086.c

> +++ b/drivers/gpio/gpio-tps65086.c

> @@ -1,16 +1,8 @@

> +// SPDX-License-Identifier: GPL-2.0

>   /*

>    * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/

>    *	Andrew F. Davis <afd@ti.com>

>    *

> - * This program is free software; you can redistribute it and/or

> - * modify it under the terms of the GNU General Public License version 2 as

> - * published by the Free Software Foundation.

> - *

> - * This program is distributed "as is" WITHOUT ANY WARRANTY of any

> - * kind, whether expressed or implied; without even the implied warranty

> - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

> - * GNU General Public License version 2 for more details.

> - *

>    * Based on the TPS65912 driver

>    */

>   

> diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c

> index f7404a6de55a..9b6cc74f47c8 100644

> --- a/drivers/gpio/gpio-tps6586x.c

> +++ b/drivers/gpio/gpio-tps6586x.c

> @@ -1,3 +1,4 @@

> +// SPDX-License-Identifier: GPL-2.0

>   /*

>    * TI TPS6586x GPIO driver

>    *

> @@ -7,18 +8,6 @@

>    * Based on tps6586x.c

>    * Copyright (c) 2010 CompuLab Ltd.

>    * Mike Rapoport <mike@compulab.co.il>

> - *

> - * This program is free software; you can redistribute it and/or modify it

> - * under the terms and conditions of the GNU General Public License,

> - * version 2, as published by the Free Software Foundation.

> - *

> - * This program is distributed in the hope it will be useful, but WITHOUT

> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or

> - * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for

> - * more details.

> - *

> - * You should have received a copy of the GNU General Public License

> - * along with this program.  If not, see <http://www.gnu.org/licenses/>.

>    */

>   

>   #include <linux/errno.h>

> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c

> index 55c745b53d0f..0c785b0fd161 100644

> --- a/drivers/gpio/gpio-tps65910.c

> +++ b/drivers/gpio/gpio-tps65910.c

> @@ -1,3 +1,4 @@

> +// SPDX-License-Identifier: GPL-2.0+

>   /*

>    * TI TPS6591x GPIO driver

>    *

> @@ -5,12 +6,6 @@

>    *

>    * Author: Graeme Gregory <gg@slimlogic.co.uk>

>    * Author: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>

> - *

> - *  This program is free software; you can redistribute it and/or modify it

> - *  under  the terms of the GNU General  Public License as published by the

> - *  Free Software Foundation;  either version 2 of the License, or (at your

> - *  option) any later version.

> - *

>    */

>   

>   #include <linux/kernel.h>

> diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c

> index aac78d18437d..140b8786b545 100644

> --- a/drivers/gpio/gpio-tps65912.c

> +++ b/drivers/gpio/gpio-tps65912.c

> @@ -1,18 +1,10 @@

> +// SPDX-License-Identifier: GPL-2.0

>   /*

>    * GPIO driver for TI TPS65912x PMICs

>    *

>    * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/

>    *	Andrew F. Davis <afd@ti.com>

>    *

> - * This program is free software; you can redistribute it and/or

> - * modify it under the terms of the GNU General Public License version 2 as

> - * published by the Free Software Foundation.

> - *

> - * This program is distributed "as is" WITHOUT ANY WARRANTY of any

> - * kind, whether expressed or implied; without even the implied warranty

> - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

> - * GNU General Public License version 2 for more details.

> - *

>    * Based on the Arizona GPIO driver and the previous TPS65912 driver by

>    * Margarita Olaya Cabrera <magi@slimlogic.co.uk>

>    */

>
Linus Walleij Aug. 30, 2018, 7:20 a.m. | #3
On Wed, Aug 29, 2018 at 5:08 PM Andrew F. Davis <afd@ti.com> wrote:
> On 08/29/2018 09:58 AM, Linus Walleij wrote:

> > I'm tired of boilerplate, use the SPDX tag.

> >

> > Cc: Andrew F. Davis <afd@ti.com>

> > Cc: Keerthy <j-keerthy@ti.com>

> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> > ---

>

>

> I'm assuming this will be done for all GPIO drivers at some point? Why

> not one big conversion patch, or at least all by TI in one go. Anyway,

>

> Acked-by: Andrew F. Davis <afd@ti.com>


Thanks! :)

I'm doing it on a drive-by-basis, so now when fixing header includes I
fix some random other stuff like this.

A bunch of drivers were already converted in Gregs initial "big
patch" for license tags.

Yours,
Linus Walleij

Patch

diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c
index 47a8b209183c..2eea98ff4ea3 100644
--- a/drivers/gpio/gpio-tps65086.c
+++ b/drivers/gpio/gpio-tps65086.c
@@ -1,16 +1,8 @@ 
+// SPDX-License-Identifier: GPL-2.0
 /*
  * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/
  *	Andrew F. Davis <afd@ti.com>
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether expressed or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License version 2 for more details.
- *
  * Based on the TPS65912 driver
  */
 
diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c
index f7404a6de55a..9b6cc74f47c8 100644
--- a/drivers/gpio/gpio-tps6586x.c
+++ b/drivers/gpio/gpio-tps6586x.c
@@ -1,3 +1,4 @@ 
+// SPDX-License-Identifier: GPL-2.0
 /*
  * TI TPS6586x GPIO driver
  *
@@ -7,18 +8,6 @@ 
  * Based on tps6586x.c
  * Copyright (c) 2010 CompuLab Ltd.
  * Mike Rapoport <mike@compulab.co.il>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <linux/errno.h>
diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
index 55c745b53d0f..0c785b0fd161 100644
--- a/drivers/gpio/gpio-tps65910.c
+++ b/drivers/gpio/gpio-tps65910.c
@@ -1,3 +1,4 @@ 
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * TI TPS6591x GPIO driver
  *
@@ -5,12 +6,6 @@ 
  *
  * Author: Graeme Gregory <gg@slimlogic.co.uk>
  * Author: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
- *
- *  This program is free software; you can redistribute it and/or modify it
- *  under  the terms of the GNU General  Public License as published by the
- *  Free Software Foundation;  either version 2 of the License, or (at your
- *  option) any later version.
- *
  */
 
 #include <linux/kernel.h>
diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c
index aac78d18437d..140b8786b545 100644
--- a/drivers/gpio/gpio-tps65912.c
+++ b/drivers/gpio/gpio-tps65912.c
@@ -1,18 +1,10 @@ 
+// SPDX-License-Identifier: GPL-2.0
 /*
  * GPIO driver for TI TPS65912x PMICs
  *
  * Copyright (C) 2015 Texas Instruments Incorporated - http://www.ti.com/
  *	Andrew F. Davis <afd@ti.com>
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether expressed or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License version 2 for more details.
- *
  * Based on the Arizona GPIO driver and the previous TPS65912 driver by
  * Margarita Olaya Cabrera <magi@slimlogic.co.uk>
  */