diff mbox series

sbus: Use of_get_child_by_name helper

Message ID 20180829200337.15352-1-robh@kernel.org
State Accepted
Commit df58f37b5d8f883fb18ba85e8d9a624154879832
Headers show
Series sbus: Use of_get_child_by_name helper | expand

Commit Message

Rob Herring Aug. 29, 2018, 8:03 p.m. UTC 
Use the of_get_child_by_name() helper instead of open coding searching
for the '/options' node. This removes directly accessing the name
pointer as well.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>

---
 drivers/sbus/char/openprom.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

-- 
2.17.1

Comments

David Miller Oct. 8, 2018, 5:57 a.m. UTC | #1 
From: Rob Herring <robh@kernel.org>

Date: Wed, 29 Aug 2018 15:03:37 -0500

> Use the of_get_child_by_name() helper instead of open coding searching

> for the '/options' node. This removes directly accessing the name

> pointer as well.

> 

> Cc: "David S. Miller" <davem@davemloft.net>

> Cc: sparclinux@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>


Applied.
diff mbox series

Patch

diff --git a/drivers/sbus/char/openprom.c b/drivers/sbus/char/openprom.c
index 7b31f19ade83..050879a2ddef 100644
--- a/drivers/sbus/char/openprom.c
+++ b/drivers/sbus/char/openprom.c
@@ -715,22 +715,13 @@  static struct miscdevice openprom_dev = {
 
 static int __init openprom_init(void)
 {
-	struct device_node *dp;
 	int err;
 
 	err = misc_register(&openprom_dev);
 	if (err)
 		return err;
 
-	dp = of_find_node_by_path("/");
-	dp = dp->child;
-	while (dp) {
-		if (!strcmp(dp->name, "options"))
-			break;
-		dp = dp->sibling;
-	}
-	options_node = dp;
-
+	options_node = of_get_child_by_name(of_find_node_by_path("/"), "options");
 	if (!options_node) {
 		misc_deregister(&openprom_dev);
 		return -EIO;