From patchwork Tue Feb 5 00:57:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 14550 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 3336023F8B for ; Tue, 5 Feb 2013 00:57:27 +0000 (UTC) Received: from mail-vb0-f47.google.com (mail-vb0-f47.google.com [209.85.212.47]) by fiordland.canonical.com (Postfix) with ESMTP id 8F8DCA1966A for ; Tue, 5 Feb 2013 00:57:26 +0000 (UTC) Received: by mail-vb0-f47.google.com with SMTP id e21so4236478vbm.6 for ; Mon, 04 Feb 2013 16:57:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-mail-handler:x-originating-ip:x-report-abuse-to :x-mho-user:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent:x-gm-message-state; bh=slyevoAnWnlyUB5YOHZP+GwzSDNVwqg0KAw05G3BNgk=; b=LTH9TzDkOD2nU+YXRSx3dsYjH/Q75ol/2jeADq43aG75maA4ieiZ5lfmnBFcUA6YCi CPAuJObicPPv6pE+17wlRHAJMdT/PeMIVZB3OHeO3UX74q+WLSuc8Gp0xScLLXoiUAYE nG39wghlkdbcw2CDXgAdDWBI6I1OlkDVfWOHuBS9OBjRM02m2sFNOvJbTq/zCB6jf50B 1tSmzlVWlFzNHWRAbl23kSyWhyTCzEjPTDWKOq9jzVqrXyaw1bdjePLXen8dIFPYgBGH SsuY4nIYKjLbE0Snk+DI34G6wi2q7p64pX9aYMI+uLdPFgPcD2UP+oj60Y7WsKmoxC/C sRZw== X-Received: by 10.220.219.204 with SMTP id hv12mr24573304vcb.71.1360025846073; Mon, 04 Feb 2013 16:57:26 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.252.8 with SMTP id zo8csp114312vec; Mon, 4 Feb 2013 16:57:25 -0800 (PST) X-Received: by 10.58.134.14 with SMTP id pg14mr21432756veb.42.1360025845384; Mon, 04 Feb 2013 16:57:25 -0800 (PST) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org. [204.13.248.66]) by mx.google.com with ESMTPS id et5si4842205vdb.146.2013.02.04.16.57.24 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 04 Feb 2013 16:57:25 -0800 (PST) Received-SPF: neutral (google.com: 204.13.248.66 is neither permitted nor denied by best guess record for domain of tony@atomide.com) client-ip=204.13.248.66; Authentication-Results: mx.google.com; spf=neutral (google.com: 204.13.248.66 is neither permitted nor denied by best guess record for domain of tony@atomide.com) smtp.mail=tony@atomide.com Received: from c-50-131-214-131.hsd1.ca.comcast.net ([50.131.214.131] helo=localhost.localdomain) by mho-01-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1U2Wqi-000NMY-C5; Tue, 05 Feb 2013 00:57:24 +0000 Received: from Mutt by mutt-smtp-wrapper.pl 1.2 (www.zdo.com/articles/mutt-smtp-wrapper.shtml) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/V1Q6oYqp9xMneKT/gVViK Date: Mon, 4 Feb 2013 16:57:21 -0800 From: Tony Lindgren To: Haojian Zhuang Cc: swarren@nvidia.com, patches@linaro.org, linux@arm.linux.org.uk, shiraz.linux.kernel@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 08/12] pinctrl: generic: dump pin configuration Message-ID: <20130205005720.GD25185@atomide.com> References: <1359825953-15663-1-git-send-email-haojian.zhuang@linaro.org> <1359825953-15663-9-git-send-email-haojian.zhuang@linaro.org> <20130205003535.GB25185@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130205003535.GB25185@atomide.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Gm-Message-State: ALoCoQlH0N/9AoS5XrGg3e9OhzT4FksTZb3L5+XCRAqN60uk7N6HOJBR+nO3g4frixC7+cVvxzWk * Tony Lindgren [130204 16:42]: > * Haojian Zhuang [130202 09:30]: > > @@ -114,4 +116,10 @@ static inline void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, > > return; > > } > > > > +static void pinconf_generic_dump_config(struct pinctrl_dev *pctldev, > > + struct seq_file *s, > > + unsigned long config) > > +{ > > + return; > > +} > > #endif > > This needs to be static inline void to avoid the following warning: > > drivers/pinctrl/pinconf.h:122: warning: ‘pinconf_generic_dump_config’ defined but not used Actually this patch needs few other changes to export it and compile, here's the version that worked for me with pinctlr-single as a module: --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -120,4 +121,19 @@ void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, } } +int pinconf_generic_dump_config(struct pinctrl_dev *pctldev, + struct seq_file *s, unsigned long config) +{ + int i; + + for(i = 0; i < ARRAY_SIZE(conf_items); i++) { + if (pinconf_to_config_param(config) != conf_items[i].param) + continue; + seq_printf(s, "%s: 0x%x", conf_items[i].display, + pinconf_to_config_argument(config)); + } + + return 0; +} +EXPORT_SYMBOL(pinconf_generic_dump_config); #endif diff --git a/drivers/pinctrl/pinconf.h b/drivers/pinctrl/pinconf.h index e3ed8cb..c91ea3e 100644 --- a/drivers/pinctrl/pinconf.h +++ b/drivers/pinctrl/pinconf.h @@ -98,6 +98,8 @@ void pinconf_generic_dump_pin(struct pinctrl_dev *pctldev, void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, struct seq_file *s, const char *gname); +int pinconf_generic_dump_config(struct pinctrl_dev *pctldev, + struct seq_file *s, unsigned long config); #else static inline void pinconf_generic_dump_pin(struct pinctrl_dev *pctldev, @@ -114,4 +116,10 @@ static inline void pinconf_generic_dump_group(struct pinctrl_dev *pctldev, return; } +static inline int pinconf_generic_dump_config(struct pinctrl_dev *pctldev, + struct seq_file *s, + unsigned long config) +{ + return; +} #endif