From patchwork Thu Aug 30 18:01:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 145553 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp195839ljw; Thu, 30 Aug 2018 11:01:17 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYLJ7E0rld8U67oh1slNnq5BcibyoY00GPgquzccXSttw2OB3nBz9ib1wNS2WoRQiDY9bbZ X-Received: by 2002:a65:5288:: with SMTP id y8-v6mr10766038pgp.284.1535652077103; Thu, 30 Aug 2018 11:01:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535652077; cv=none; d=google.com; s=arc-20160816; b=zRtBFXuu7inooDEfYkzuds2jKHLy2CNHgO+blAOAmUz9wpOWFGCRN7iQQQ/mzaQOPp +bFWpBkfOyiNhZ52iceRcfdNnuliNaSb/QE67N+qBc1brAqyeus4fX9oBPhsSc5JXGk7 hrleLQH35jWbHojyS55uhsDwG7g43T3ZWP683O5eBrYpBiFCDZGkjBRLAuX49qA11JvX igmjJ31Ge++RjaJMgKPwlUwhdBIaiApCCHF/21mU63CYyQ8fpmYiwu0X4aZIIBFt0y0C sVioeYx5oxElGHXbX1sGsCrXpgOs2CDS4meznq8X2iT2dNVE55qD9evpGPkcRagf1eXX fWAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=SB09djoriHEeyyZLPKR1IU15DTUWw8x1Xn8o/GZfmW8=; b=pAO8venlUQMTaoQ5C5AChy6jXnQeYs3PeIUdAo5FKAaeZqsnvA+vYsrCpTxHLbf689 3VuC/Sn8SyIheKdh6vnk/QI55saM4txzFdX2s23cvfGaacCvc9/rgHC+GS/uKhNJjgIR PapeSkXo57odPQWZn9YO3mAR5POPgHPzpeJ47hrHmAOTegl2OtXaRp+9RBANjsFDUV4C gx+SqeNNXrSNZv8pa8hZMhklot6gl6g8MCgMfQCtgGyscl7ewV5LS7m5jZMZw6/gQ4Q7 CsnMUkk6FDs73zmzgzxt3UooxzP1MPFf9PlEmAKveMjO174lgAlB8QDodU8UELZcZLao 0NPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b="Z/AWs7Cg"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a64-v6si7831055pfb.224.2018.08.30.11.01.16; Thu, 30 Aug 2018 11:01:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b="Z/AWs7Cg"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725836AbeH3WEf (ORCPT + 13 others); Thu, 30 Aug 2018 18:04:35 -0400 Received: from mail-eopbgr690114.outbound.protection.outlook.com ([40.107.69.114]:18358 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726674AbeH3WEe (ORCPT ); Thu, 30 Aug 2018 18:04:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SB09djoriHEeyyZLPKR1IU15DTUWw8x1Xn8o/GZfmW8=; b=Z/AWs7CgJPk66S5xtrjv7/uz+c7agEXSOQLXM9aB81TL4ZCc9JIODBO8Szz8sTa7wL9GV8upS6lj0RpHh3BjO4cqA/REIGvcCQqXPeKUuXbetM4J19FDdp8NmmkCHVd5L3LxM3UInkhibms/S1LMZ/bDFxIdenQxQhbkee+lqaw= Received: from CY4PR21MB0776.namprd21.prod.outlook.com (10.173.192.22) by CY4PR21MB0165.namprd21.prod.outlook.com (10.173.192.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.2; Thu, 30 Aug 2018 18:01:12 +0000 Received: from CY4PR21MB0776.namprd21.prod.outlook.com ([fe80::7c3a:eea8:1391:1611]) by CY4PR21MB0776.namprd21.prod.outlook.com ([fe80::7c3a:eea8:1391:1611%7]) with mapi id 15.20.1122.009; Thu, 30 Aug 2018 18:01:12 +0000 From: Sasha Levin To: "stable@vger.kernel.org" CC: Arnd Bergmann , Ganesh Goudar , "David S. Miller" , Rahul Lakkireddy , Alexey Dobriyan , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH AUTOSEL 4.18 006/113] fs/proc/vmcore.c: hide vmcoredd_mmap_dumps() for nommu builds Thread-Topic: [PATCH AUTOSEL 4.18 006/113] fs/proc/vmcore.c: hide vmcoredd_mmap_dumps() for nommu builds Thread-Index: AQHUQItwG1tsI/zpdUCbk4OhQAzIMg== Date: Thu, 30 Aug 2018 18:01:12 +0000 Message-ID: <20180830180050.35735-6-alexander.levin@microsoft.com> References: <20180830180050.35735-1-alexander.levin@microsoft.com> In-Reply-To: <20180830180050.35735-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR21MB0165; 6:vLn4JkpGmPD7u5Hf1rAiJG8ob/e8UVHtfrDIqzef5J+VvQPvlypxZ6fueVbCrdAphh/xixa1FFEtMhu+5PWEcqwvO3VmMYMz1b1C6+hmUXtOJkJtPDYkMHqMgRr70B7uDHtbrTZ+te1qBDFHKaElIHjK9lbXoNJPy18+ePp0YVuiAK2Y30F55iR1G8SQ0hGJOMLR/XJBUwNCNFyZZqZSaIwts8oC8B1BX51YdLdHhwRl0Kw/Q7HVQbvseSaYHBtbKhansZpPLU22zixiZpyERzcYEikEG8dkMfFEHY7qG60VP9RIQkxjMfkNY8kdaYnKWBOqIRSxjh69K55Ky8eZeMGMTXWf03//LSVATgyH7EdyQrHedB+uliMv7iM1o0yCti+h12/NvdgLsMrR+6ycleGyx/BeamAsNNXwsFSUV+Pfo5pHKJ5pnnNe7cD+paJoXv/Izuki/UNaxOQhoHJB+A==; 5:aW25qyqCXbK6fSIhUsnWgQ3okKgHlr+awsaU8z4xToqUPrZefmf5tBxvQ8H/poYRlY8TeVDp+cOisYglSGwEizORm2Xt9P4dp0PsdjnfLF1hlfygBNCrzAv5LtC+NKXph8ZbcQTnYnhcd9gcLjQYuiClJaZvcRrTOFJx9AogbVc=; 7:HLK+Va2eYM+6/xTEoqRIBh6DGqS/cPKh+TEt2qLXuKUfUE8MQbPeYn6usGUSMwu14RPb7yqhpNLW22gEROO06z0aavAgRhGVC3iXLiHe2CfE6OG4xSAjVQ1dkgwDILy1zm7UtQxydj2utN8zEhOnn73epv6wuPR2+2DdRwIpiO8HcC1Hr+GKpP5YeH680F+DObWnaJP7I4EYG9gfCtERNLvw6OIgkMvKHGiqaaFGG3RYUvY8Ia02KhKuDNHUHLxJ x-ms-office365-filtering-correlation-id: 123b4158-f7d1-4f8d-90c8-08d60ea2929a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(4534165)(4627221)(201703031133081)(201702281549075)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:CY4PR21MB0165; x-ms-traffictypediagnostic: CY4PR21MB0165: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(42068640409301); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231340)(944501410)(52105095)(2018427008)(3002001)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699049)(76991033); SRVR:CY4PR21MB0165; BCL:0; PCL:0; RULEID:; SRVR:CY4PR21MB0165; x-forefront-prvs: 07807C55DC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(346002)(376002)(396003)(366004)(39860400002)(199004)(189003)(14454004)(1076002)(14444005)(966005)(256004)(316002)(3846002)(6116002)(2900100001)(99286004)(10090500001)(54906003)(22452003)(8676002)(486006)(102836004)(97736004)(476003)(107886003)(2616005)(6506007)(4326008)(25786009)(26005)(186003)(217873002)(72206003)(10290500003)(76176011)(478600001)(39060400002)(446003)(11346002)(8936002)(81156014)(81166006)(68736007)(106356001)(2351001)(105586002)(5250100002)(575784001)(2501003)(86362001)(2906002)(36756003)(1730700003)(86612001)(6916009)(53936002)(6486002)(6512007)(7736002)(305945005)(6306002)(66066001)(5660300001)(6436002)(5640700003); DIR:OUT; SFP:1102; SCL:1; SRVR:CY4PR21MB0165; H:CY4PR21MB0776.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: FZt3I403ySu9SETjES60CkgFslF36yEfiL2Pa0SAqv5vCgr9EXwXXMEob/V/LRIjH3rt10kizgRm8nPIIe44sa5juKDOz6mdc4eF3qxmAc7rG40CgsyB51fNGBfAzmMTLIoP04qyIo7GdYrHRHN2c4ws7yp/8pHaZkiR9cQZfPTsLJfQoJbqPe6hUblCPFz8VE22NK91U7u+noIYD5Gf+10ebp3rHkSfYsv8Iuf2m14a9r9kP5XKencEQEGf2DIoM21DlhOU7j8GcLPcwCpJllWhJEfeNsR2JOveBgmf5fCGPNEd9ErT7Y/Voj1VvZ10Y8oFuhz9MbZzkD1IVSWTSwp8Kjv+MlZilhCCxiiyav4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 123b4158-f7d1-4f8d-90c8-08d60ea2929a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2018 18:01:12.5436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0165 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit a2036a1ef2ee91acab01a0ae4a534070691a42ec ] Without CONFIG_MMU, we get a build warning: fs/proc/vmcore.c:228:12: error: 'vmcoredd_mmap_dumps' defined but not used [-Werror=unused-function] static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst, The function is only referenced from an #ifdef'ed caller, so this uses the same #ifdef around it. Link: http://lkml.kernel.org/r/20180525213526.2117790-1-arnd@arndb.de Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes") Signed-off-by: Arnd Bergmann Cc: Ganesh Goudar Cc: "David S. Miller" Cc: Rahul Lakkireddy Cc: Alexey Dobriyan Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- fs/proc/vmcore.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index cfb6674331fd..0651646dd04d 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -225,6 +225,7 @@ static int vmcoredd_copy_dumps(void *dst, u64 start, size_t size, int userbuf) return ret; } +#ifdef CONFIG_MMU static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst, u64 start, size_t size) { @@ -259,6 +260,7 @@ static int vmcoredd_mmap_dumps(struct vm_area_struct *vma, unsigned long dst, mutex_unlock(&vmcoredd_mutex); return ret; } +#endif /* CONFIG_MMU */ #endif /* CONFIG_PROC_VMCORE_DEVICE_DUMP */ /* Read from the ELF header and then the crash dump. On error, negative value is