[v3,18/20] test_avb: Update pymark.buildconfigspec information for the AVB tests

Message ID 20180903144711.31585-19-jens.wiklander@linaro.org
State Superseded
Headers show
Series
  • AVB using OP-TEE
Related show

Commit Message

Jens Wiklander Sept. 3, 2018, 2:47 p.m.
Update the pymark.buildconfigspec to depend on 'cmd_mmc' in addition to
'cmd_avb' for those tests that needs more a more complete MMC
implementation or the "mmc" command.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>

---
 test/py/tests/test_avb.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

-- 
2.17.1

Comments

Simon Glass Sept. 14, 2018, 10:54 a.m. | #1
On 3 September 2018 at 16:47, Jens Wiklander <jens.wiklander@linaro.org> wrote:
> Update the pymark.buildconfigspec to depend on 'cmd_mmc' in addition to
> 'cmd_avb' for those tests that needs more a more complete MMC
> implementation or the "mmc" command.
>
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> ---
>  test/py/tests/test_avb.py | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Patch

diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_avb.py
index 7996e4845db3..9683fd80d074 100644
--- a/test/py/tests/test_avb.py
+++ b/test/py/tests/test_avb.py
@@ -23,7 +23,7 @@  mmc_dev = 1
 temp_addr = 0x90000000
 temp_addr2 = 0x90002000
 
-@pytest.mark.buildconfigspec('cmd_avb')
+@pytest.mark.buildconfigspec('cmd_avb', 'cmd_mmc')
 def test_avb_verify(u_boot_console):
     """Run AVB 2.0 boot verification chain with avb subset of commands
     """
@@ -36,7 +36,7 @@  def test_avb_verify(u_boot_console):
     assert response.find(success_str)
 
 
-@pytest.mark.buildconfigspec('cmd_avb')
+@pytest.mark.buildconfigspec('cmd_avb', 'cmd_mmc')
 def test_avb_mmc_uuid(u_boot_console):
     """Check if 'avb get_uuid' works, compare results with
     'part list mmc 1' output
@@ -78,6 +78,7 @@  def test_avb_read_rb(u_boot_console):
     assert response == ''
 
     response = u_boot_console.run_command('avb read_rb 1')
+    assert response == 'Rollback index: 0'
 
 
 @pytest.mark.buildconfigspec('cmd_avb')
@@ -89,9 +90,10 @@  def test_avb_is_unlocked(u_boot_console):
     assert response == ''
 
     response = u_boot_console.run_command('avb is_unlocked')
+    assert response == 'Unlocked = 1'
 
 
-@pytest.mark.buildconfigspec('cmd_avb')
+@pytest.mark.buildconfigspec('cmd_avb', 'cmd_mmc')
 def test_avb_mmc_read(u_boot_console):
     """Test mmc read operation
     """