ARM: dts: exynos: Disable pull control for MAX8997 interrupts on Origen

Message ID 20180905100215.7701-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • ARM: dts: exynos: Disable pull control for MAX8997 interrupts on Origen
Related show

Commit Message

Marek Szyprowski Sept. 5, 2018, 10:02 a.m.
PMIC_IRQB and PMIC_KEYINB lines on Exynos4210-based Origen board have
external pull-up resistors, so disable any pull control for those lines
in respective pin controller node. This fixes support for MAX8997
interrupts and enables operation of wakeup from MAX8997 RTC alarm.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/exynos4210-origen.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.17.1

Comments

Krzysztof Kozlowski Sept. 5, 2018, 1:49 p.m. | #1
On Wed, 5 Sep 2018 at 12:03, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>

> PMIC_IRQB and PMIC_KEYINB lines on Exynos4210-based Origen board have

> external pull-up resistors, so disable any pull control for those lines

> in respective pin controller node. This fixes support for MAX8997

> interrupts and enables operation of wakeup from MAX8997 RTC alarm.

>

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


Looks good. I will mark it as cc-stable:
Fixes: 17419726aaa1 ("ARM: dts: add max8997 device node for
exynos4210-origen board")
Cc: <stable@vger.kernel.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 6, 2018, 4:05 p.m. | #2
On Wed, Sep 05, 2018 at 12:02:15PM +0200, Marek Szyprowski wrote:
> PMIC_IRQB and PMIC_KEYINB lines on Exynos4210-based Origen board have

> external pull-up resistors, so disable any pull control for those lines

> in respective pin controller node. This fixes support for MAX8997

> interrupts and enables operation of wakeup from MAX8997 RTC alarm.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  arch/arm/boot/dts/exynos4210-origen.dts | 9 +++++++++

>  1 file changed, 9 insertions(+)


Thanks, applied.

Best regards,
Krzysztof

Patch

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index 2ab99f9f3d0a..dd9ec05eb0f7 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -151,6 +151,8 @@ 
 		reg = <0x66>;
 		interrupt-parent = <&gpx0>;
 		interrupts = <4 IRQ_TYPE_NONE>, <3 IRQ_TYPE_NONE>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max8997_irq>;
 
 		max8997,pmic-buck1-dvs-voltage = <1350000>;
 		max8997,pmic-buck2-dvs-voltage = <1100000>;
@@ -288,6 +290,13 @@ 
 	};
 };
 
+&pinctrl_1 {
+	max8997_irq: max8997-irq {
+		samsung,pins = "gpx0-3", "gpx0-4";
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
+};
+
 &sdhci_0 {
 	bus-width = <4>;
 	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_cd>;