[v2] mfd: max8997: Disable interrupt handling for suspend/resume cycle

Message ID 20180905143606.5916-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • [v2] mfd: max8997: Disable interrupt handling for suspend/resume cycle
Related show

Commit Message

Marek Szyprowski Sept. 5, 2018, 2:36 p.m.
Disable IRQs during suspend/resume cycle to ensure handling of wakeup
interrupts (i.e. RTC wake alarm) after max8997_resume(). This way it can
be properly handled when I2C bus is finally available. This pattern is
also used in other MAX PMIC MFD drivers.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
changelog:
v2:
- reordered the sequence of operation as suggested by Krzysztof Kozlowski
---
 drivers/mfd/max8997.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.1

Comments

Krzysztof Kozlowski Sept. 5, 2018, 4:29 p.m. | #1
On Wed, Sep 05, 2018 at 04:36:06PM +0200, Marek Szyprowski wrote:
> Disable IRQs during suspend/resume cycle to ensure handling of wakeup

> interrupts (i.e. RTC wake alarm) after max8997_resume(). This way it can

> be properly handled when I2C bus is finally available. This pattern is

> also used in other MAX PMIC MFD drivers.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

> changelog:

> v2:

> - reordered the sequence of operation as suggested by Krzysztof Kozlowski

> ---

>  drivers/mfd/max8997.c | 2 ++

>  1 file changed, 2 insertions(+)

> 


Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>


Best regards,
Krzysztof
Lee Jones Sept. 11, 2018, 2:53 p.m. | #2
On Wed, 05 Sep 2018, Marek Szyprowski wrote:

> Disable IRQs during suspend/resume cycle to ensure handling of wakeup

> interrupts (i.e. RTC wake alarm) after max8997_resume(). This way it can

> be properly handled when I2C bus is finally available. This pattern is

> also used in other MAX PMIC MFD drivers.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

> changelog:

> v2:

> - reordered the sequence of operation as suggested by Krzysztof Kozlowski

> ---

>  drivers/mfd/max8997.c | 2 ++

>  1 file changed, 2 insertions(+)


Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
index 3f554c447521..b17eff50ad52 100644
--- a/drivers/mfd/max8997.c
+++ b/drivers/mfd/max8997.c
@@ -468,6 +468,7 @@  static int max8997_suspend(struct device *dev)
 	struct i2c_client *i2c = to_i2c_client(dev);
 	struct max8997_dev *max8997 = i2c_get_clientdata(i2c);
 
+	disable_irq(max8997->irq);
 	if (device_may_wakeup(dev))
 		irq_set_irq_wake(max8997->irq, 1);
 	return 0;
@@ -480,6 +481,7 @@  static int max8997_resume(struct device *dev)
 
 	if (device_may_wakeup(dev))
 		irq_set_irq_wake(max8997->irq, 0);
+	enable_irq(max8997->irq);
 	return max8997_irq_resume(max8997);
 }