ARM: dts: exynos: Add missing PMIC interrupts on UniversalC210 board

Message ID 20180905144443.6160-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • ARM: dts: exynos: Add missing PMIC interrupts on UniversalC210 board
Related show

Commit Message

Marek Szyprowski Sept. 5, 2018, 2:44 p.m.
PMIC node requires external interrupts for proper operation. Lack of them
was probably caused by a limited support for interrupts from more than one
parent, which was not possible to define when support for this board was
added. Fix this by adding 'interrupt-extended' property and properly
define both interrupt lines for PMIC node.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/exynos4210-universal_c210.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.17.1

Comments

Krzysztof Kozlowski Sept. 6, 2018, 4:07 p.m. | #1
On Wed, Sep 05, 2018 at 04:44:43PM +0200, Marek Szyprowski wrote:
> PMIC node requires external interrupts for proper operation. Lack of them

> was probably caused by a limited support for interrupts from more than one

> parent, which was not possible to define when support for this board was

> added. Fix this by adding 'interrupt-extended' property and properly

> define both interrupt lines for PMIC node.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  arch/arm/boot/dts/exynos4210-universal_c210.dts | 8 ++++++++

>  1 file changed, 8 insertions(+)


Thanks, applied.

Best regards,
Krzysztof

Patch

diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 4e6ff97e1ec4..a341ac3547cc 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -310,6 +310,9 @@ 
 
 	pmic@66 {
 		compatible = "national,lp3974";
+		interrupts-extended = <&gpx0 7 0>, <&gpx2 7 0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&lp3974_irq>;
 		reg = <0x66>;
 
 		max8998,pmic-buck1-default-dvs-idx = <0>;
@@ -507,6 +510,11 @@ 
 		samsung,pins = "gpx3-7";
 		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
 	};
+
+	lp3974_irq: lp3974-irq {
+		samsung,pins = "gpx0-7", "gpx2-7";
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
 };
 
 &pinctrl_0 {