ARM: dts: exynos: Disable pull control for PMIC IRQ line on Artik5 board

Message ID 20180907074659.4297-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • ARM: dts: exynos: Disable pull control for PMIC IRQ line on Artik5 board
Related show

Commit Message

Marek Szyprowski Sept. 7, 2018, 7:46 a.m.
S2MPS14 PMIC interrupt line on Exynos3250-based Artik5 evaluation board
has external pull-up resistors, so disable any pull control for it in
controller node. This fixes support for S2MPS14 PMIC interrupts and
enables operation of wakeup from S2MPS14 RTC alarm.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 arch/arm/boot/dts/exynos3250-artik5.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.17.1

Comments

Krzysztof Kozlowski Sept. 10, 2018, 4:59 p.m. | #1
On Fri, Sep 07, 2018 at 09:46:59AM +0200, Marek Szyprowski wrote:
> S2MPS14 PMIC interrupt line on Exynos3250-based Artik5 evaluation board

> has external pull-up resistors, so disable any pull control for it in

> controller node. This fixes support for S2MPS14 PMIC interrupts and

> enables operation of wakeup from S2MPS14 RTC alarm.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  arch/arm/boot/dts/exynos3250-artik5.dtsi | 7 +++++++


Thanks, applied.

Best regards,
Krzysztof

Patch

diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.dtsi
index 620b50c19ead..7c22cbf6f3d4 100644
--- a/arch/arm/boot/dts/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/exynos3250-artik5.dtsi
@@ -69,6 +69,8 @@ 
 		compatible = "samsung,s2mps14-pmic";
 		interrupt-parent = <&gpx3>;
 		interrupts = <5 IRQ_TYPE_NONE>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&s2mps14_irq>;
 		reg = <0x66>;
 
 		s2mps14_osc: clocks {
@@ -350,6 +352,11 @@ 
 		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
 		samsung,pin-val = <1>;
 	};
+
+	s2mps14_irq: s2mps14-irq {
+		samsung,pins = "gpx3-5";
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
 };
 
 &rtc {