| Message ID | 1360151235-11980-2-git-send-email-haojian.zhuang@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Please include Russell on patches to this driver. On Wed, Feb 6, 2013 at 12:47 PM, Haojian Zhuang <haojian.zhuang@linaro.org> wrote: > If amba serial driver is probed defer, amba serial driver may be > probed after init process. So the error log shows in below. > > [ 0.389403] Warning: unable to open an initial console. > [ 0.390107] Freeing init memory: 2328K > > It results in serial console not enabled. So replace arch_initcall > by module_init on pl011_init(). The boot sequence is changed in below. > > pinctrl driver --> amba serial driver --> init process ONLY on systems using pinctrl, nota bene. > Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Alan Cox <alan@linux.intel.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-serial@vger.kernel.org > --- > drivers/tty/serial/amba-pl011.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > index d43d530..8b7dacb 100644 > --- a/drivers/tty/serial/amba-pl011.c > +++ b/drivers/tty/serial/amba-pl011.c > @@ -2129,11 +2129,7 @@ static void __exit pl011_exit(void) > uart_unregister_driver(&amba_reg); > } > > -/* > - * While this can be a module, if builtin it's most likely the console > - * So let's leave module_exit but move module_init to an earlier place > - */ > -arch_initcall(pl011_init); > +module_init(pl011_init); Hm. PL011 is actually the only serial driver that gets called as arch_initcall(). Alessandro Rubini changed this in 2009. Alessandro, can you explain? Is the sole purpose to get the console up early? Yours, Linus Walleij
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index d43d530..8b7dacb 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2129,11 +2129,7 @@ static void __exit pl011_exit(void) uart_unregister_driver(&amba_reg); } -/* - * While this can be a module, if builtin it's most likely the console - * So let's leave module_exit but move module_init to an earlier place - */ -arch_initcall(pl011_init); +module_init(pl011_init); module_exit(pl011_exit); MODULE_AUTHOR("ARM Ltd/Deep Blue Solutions Ltd");
If amba serial driver is probed defer, amba serial driver may be probed after init process. So the error log shows in below. [ 0.389403] Warning: unable to open an initial console. [ 0.390107] Freeing init memory: 2328K It results in serial console not enabled. So replace arch_initcall by module_init on pl011_init(). The boot sequence is changed in below. pinctrl driver --> amba serial driver --> init process Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org> Cc: Alan Cox <alan@linux.intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-serial@vger.kernel.org --- drivers/tty/serial/amba-pl011.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)