diff mbox series

[2/2] kbuild: remove dead code in cmd_files calculation in top Makefile

Message ID 1536734610-22173-2-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 00d78ab2ba756af7b9a4dacd437b7a882bd18a4b
Headers show
Series [1/2] kbuild: hide most of targets when running config or mixed targets | expand

Commit Message

Masahiro Yamada Sept. 12, 2018, 6:43 a.m. UTC
Nobody sets 'targets' in the top-level Makefile or arch/*/Makefile,
hence $(targets) is empty.

$(wildcard .*.cmd) will do for including the .vmlinux.cmd file.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

---

 Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.7.4

Comments

Masahiro Yamada Sept. 14, 2018, 1:06 p.m. UTC | #1
2018-09-12 15:43 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Nobody sets 'targets' in the top-level Makefile or arch/*/Makefile,

> hence $(targets) is empty.

>

> $(wildcard .*.cmd) will do for including the .vmlinux.cmd file.

>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> ---


Applied to linux-kbuild.


>  Makefile | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

>

> diff --git a/Makefile b/Makefile

> index 4b76e22..8f6dbfc 100644

> --- a/Makefile

> +++ b/Makefile

> @@ -1721,8 +1721,7 @@ cmd_crmodverdir = $(Q)mkdir -p $(MODVERDIR) \

>                    $(if $(KBUILD_MODULES),; rm -f $(MODVERDIR)/*)

>

>  # read all saved command lines

> -

> -cmd_files := $(wildcard .*.cmd $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))

> +cmd_files := $(wildcard .*.cmd)

>

>  ifneq ($(cmd_files),)

>    $(cmd_files): ;      # Do not try to update included dependency files

> --

> 2.7.4

>




-- 
Best Regards
Masahiro Yamada
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 4b76e22..8f6dbfc 100644
--- a/Makefile
+++ b/Makefile
@@ -1721,8 +1721,7 @@  cmd_crmodverdir = $(Q)mkdir -p $(MODVERDIR) \
                   $(if $(KBUILD_MODULES),; rm -f $(MODVERDIR)/*)
 
 # read all saved command lines
-
-cmd_files := $(wildcard .*.cmd $(foreach f,$(sort $(targets)),$(dir $(f)).$(notdir $(f)).cmd))
+cmd_files := $(wildcard .*.cmd)
 
 ifneq ($(cmd_files),)
   $(cmd_files): ;	# Do not try to update included dependency files