[01/11] OPP: Free OPP table properly on performance state irregularities

Message ID 14486fb4c32047983ace6af4f4ffe2366242f3b5.1536736872.git.viresh.kumar@linaro.org
State Accepted
Commit 2fbb8670b4ff4454f1c0de510f788d737edc4b90
Headers show
  • OPP: Don't create multiple OPP tables for devices sharing OPP table
Related show

Commit Message

Viresh Kumar Sept. 12, 2018, 8:28 a.m.
The OPP table was freed, but not the individual OPPs which is done from
_dev_pm_opp_remove_table(). Fix it by calling _dev_pm_opp_remove_table()
as well.

Cc: 4.18 <stable@vger.kernel.org> # v4.18
Fixes: 3ba98324e81a ("PM / OPP: Get performance state using genpd helper")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

 drivers/opp/of.c | 1 +
 1 file changed, 1 insertion(+)



diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 7af0ddec936b..20988c426650 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -425,6 +425,7 @@  static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np)
 		dev_err(dev, "Not all nodes have performance state set (%d: %d)\n",
 			count, pstate_count);
 		ret = -ENOENT;
+		_dev_pm_opp_remove_table(opp_table, dev, false);
 		goto put_opp_table;