diff mbox series

ARM: dts: stm32: Fix SPI controller node names

Message ID 20180913181245.25484-11-robh@kernel.org
State Accepted
Commit 1ba23b1df0bb6eec430408614c3a11280941e112
Headers show
Series ARM: dts: stm32: Fix SPI controller node names | expand

Commit Message

Rob Herring Sept. 13, 2018, 6:12 p.m. UTC
SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the
name enables dtc SPI bus checks.

Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Signed-off-by: Rob Herring <robh@kernel.org>

---
Please apply to the sub-arch tree. The dtc changes haven't landed, but 
will for 4.20.

 arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Alexandre TORGUE Sept. 14, 2018, 12:25 p.m. UTC | #1
On 09/13/2018 08:12 PM, Rob Herring wrote:
> SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the

> name enables dtc SPI bus checks.

> 

> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>

> Cc: Alexandre Torgue <alexandre.torgue@st.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

> Please apply to the sub-arch tree. The dtc changes haven't landed, but

> will for 4.20.


Thanks Rob. I will add it in my next PR for 4.20.

> 

>   arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi

> index 661be948ab74..0e5a2f89f2d9 100644

> --- a/arch/arm/boot/dts/stm32mp157c.dtsi

> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi

> @@ -947,7 +947,7 @@

>   			dma-requests = <48>;

>   		};

>   

> -		qspi: qspi@58003000 {

> +		qspi: spi@58003000 {

>   			compatible = "st,stm32f469-qspi";

>   			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;

>   			reg-names = "qspi", "qspi_mm";

>
Alexandre TORGUE Sept. 20, 2018, 2:56 p.m. UTC | #2
Hi Rob

On 09/13/2018 08:12 PM, Rob Herring wrote:
> SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the


I assume that you meant "SPI controller nodes should be named 'spi' 
rather than 'qspi'" (not ssp). I'll update commit message when I'll 
merge if you confirm.

regards
Alex


> name enables dtc SPI bus checks.

> 

> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>

> Cc: Alexandre Torgue <alexandre.torgue@st.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

> Please apply to the sub-arch tree. The dtc changes haven't landed, but

> will for 4.20.

> 

>   arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi

> index 661be948ab74..0e5a2f89f2d9 100644

> --- a/arch/arm/boot/dts/stm32mp157c.dtsi

> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi

> @@ -947,7 +947,7 @@

>   			dma-requests = <48>;

>   		};

>   

> -		qspi: qspi@58003000 {

> +		qspi: spi@58003000 {

>   			compatible = "st,stm32f469-qspi";

>   			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;

>   			reg-names = "qspi", "qspi_mm";

>
Alexandre TORGUE Sept. 21, 2018, 12:56 p.m. UTC | #3
Hi Rob

On 09/13/2018 08:12 PM, Rob Herring wrote:
> SPI controller nodes should be named 'spi' rather than 'ssp'. Fixing the

> name enables dtc SPI bus checks.

> 

> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>

> Cc: Alexandre Torgue <alexandre.torgue@st.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

> Please apply to the sub-arch tree. The dtc changes haven't landed, but

> will for 4.20.

> 

>   arch/arm/boot/dts/stm32mp157c.dtsi | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi

> index 661be948ab74..0e5a2f89f2d9 100644

> --- a/arch/arm/boot/dts/stm32mp157c.dtsi

> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi

> @@ -947,7 +947,7 @@

>   			dma-requests = <48>;

>   		};

>   

> -		qspi: qspi@58003000 {

> +		qspi: spi@58003000 {

>   			compatible = "st,stm32f469-qspi";

>   			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;

>   			reg-names = "qspi", "qspi_mm";

> 


After fixup commmit message:

Applied on stm32-next.

Thanks.
Alex
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index 661be948ab74..0e5a2f89f2d9 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -947,7 +947,7 @@ 
 			dma-requests = <48>;
 		};
 
-		qspi: qspi@58003000 {
+		qspi: spi@58003000 {
 			compatible = "st,stm32f469-qspi";
 			reg = <0x58003000 0x1000>, <0x70000000 0x10000000>;
 			reg-names = "qspi", "qspi_mm";