| Message ID | 1537243113-1710-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 5318321d367c21ca1fe9eb00caefc239c938750a |
| Headers | show |
| Series | samples: disable CONFIG_SAMPLES for UML | expand |
Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada: > Some samples require headers installation, so commit 3fca1700c4c3 > ("kbuild: make samples really depend on headers_install") added > such dependency in the top Makefile. However, UML fails to build > with CONFIG_SAMPLES=y because UML does not support headers_install. > > Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") > Reported-by: Kees Cook <keescook@chromium.org> > Cc: David Howells <dhowells@redhat.com> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Is there anything UML can do better? Not sure whether an arch like is supposed to install headers at all, I guess no. :) Thanks, //richard
Hi. 2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@nod.at>: > Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada: >> Some samples require headers installation, so commit 3fca1700c4c3 >> ("kbuild: make samples really depend on headers_install") added >> such dependency in the top Makefile. However, UML fails to build >> with CONFIG_SAMPLES=y because UML does not support headers_install. >> >> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") >> Reported-by: Kees Cook <keescook@chromium.org> >> Cc: David Howells <dhowells@redhat.com> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Is there anything UML can do better? > Not sure whether an arch like is supposed to install headers at all, > I guess no. :) I just thought suppressing CONFIG_SAMPLES was a big hammer. We could install host-arch headers for UML if we like, but I am not sure whether is is sensible... Wait for comments in case somebody has a better solution. -- Best Regards Masahiro Yamada
2018年9月19日(水) 15:58 Masahiro Yamada <yamada.masahiro@socionext.com>: > > Hi. > > 2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@nod.at>: > > Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada: > >> Some samples require headers installation, so commit 3fca1700c4c3 > >> ("kbuild: make samples really depend on headers_install") added > >> such dependency in the top Makefile. However, UML fails to build > >> with CONFIG_SAMPLES=y because UML does not support headers_install. > >> > >> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") > >> Reported-by: Kees Cook <keescook@chromium.org> > >> Cc: David Howells <dhowells@redhat.com> > >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > > Is there anything UML can do better? > > Not sure whether an arch like is supposed to install headers at all, > > I guess no. :) > > I just thought suppressing CONFIG_SAMPLES was a big hammer. > > We could install host-arch headers for UML if we like, > but I am not sure whether is is sensible... > > Wait for comments in case somebody has a better solution. > I started to think this is a wrong hack. I posted a different solution: https://patchwork.kernel.org/patch/10619043/ -- Best Regards Masahiro Yamada
On Tue, Sep 18, 2018 at 12:59 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Some samples require headers installation, so commit 3fca1700c4c3 > ("kbuild: make samples really depend on headers_install") added > such dependency in the top Makefile. However, UML fails to build > with CONFIG_SAMPLES=y because UML does not support headers_install. > > Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") > Reported-by: Kees Cook <keescook@chromium.org> > Cc: David Howells <dhowells@redhat.com> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- I did not get any more comment. I applied to linux-kbuild/fixes. > > samples/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/Kconfig b/samples/Kconfig > index bd133ef..ad1ec701 100644 > --- a/samples/Kconfig > +++ b/samples/Kconfig > @@ -1,5 +1,6 @@ > menuconfig SAMPLES > bool "Sample kernel code" > + depends on !UML > help > You can build and test sample kernel code here. > > -- > 2.7.4 > -- Best Regards Masahiro Yamada
diff --git a/samples/Kconfig b/samples/Kconfig index bd133ef..ad1ec701 100644 --- a/samples/Kconfig +++ b/samples/Kconfig @@ -1,5 +1,6 @@ menuconfig SAMPLES bool "Sample kernel code" + depends on !UML help You can build and test sample kernel code here.
Some samples require headers installation, so commit 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") added such dependency in the top Makefile. However, UML fails to build with CONFIG_SAMPLES=y because UML does not support headers_install. Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install") Reported-by: Kees Cook <keescook@chromium.org> Cc: David Howells <dhowells@redhat.com> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- samples/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.4